Skip to content

fix: pass reason= keyword arg to web.HTTPBadRequest in emu_svc #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
deacon-mp wants to merge 2 commits into
base: master
Choose a base branch
from
Open

fix: pass reason= keyword arg to web.HTTPBadRequest in emu_svc #51

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d6e5692
fix: pass reason= keyword arg to web.HTTPBadRequest in emu_svc
deacon-mp Mar 16, 2026
658eeb2
test: add regression test for handle_forwarded_beacon HTTPBadRequest
deacon-mp Mar 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion app/emu_svc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@
except Exception as e:
error_msg = 'Server error when processing forwarded beacon: %s' % e
self.log.error(error_msg)
raise web.HTTPBadRequest(error_msg)
raise web.HTTPBadRequest(reason=error_msg)
Comment on lines 59 to +62

async def clone_repo(self, repo_url=None):
"""
Expand All @@ -71,7 +71,7 @@

if not os.path.exists(self.repo_dir) or not os.listdir(self.repo_dir):
self.log.debug('cloning repo %s' % repo_url)
check_call(['git', 'clone', '--depth', '1', repo_url, self.repo_dir], stdout=DEVNULL, stderr=STDOUT)

Check failure on line 74 in app/emu_svc.py

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use an async subprocess call in this async function instead of a synchronous one. 


See more on https://sonarcloud.io/project/issues?id=mitre_emu&issues=AZz0whmSQ_2e5Ninb8P3&open=AZz0whmSQ_2e5Ninb8P3&pullRequest=51
self.log.debug('clone complete')

async def populate_data_directory(self, library_path=None):
Expand Down
Loading