Update python Docker tag#334
Conversation
6703980 to
81019d2
Compare
27078ef to
03e6bbd
Compare
add9822 to
6ff6f77
Compare
18d988a to
672a09c
Compare
2209b8a to
bb11ce7
Compare
a5b8e81 to
a368015
Compare
d295d5a to
551144a
Compare
|
|
1fe41da to
f642a5e
Compare
f642a5e to
5670053
Compare
5670053 to
64cb9d1
Compare
93ee15f to
a22a466
Compare
bd377c6 to
b220df1
Compare
b220df1 to
b673e4a
Compare
| description = "AI applications for MIT Open Learning." | ||
| authors = [{ name = "MIT ODL" }] | ||
| requires-python = ">=3.13.7,<3.14" | ||
| requires-python = ">=3.14.3,<3.15" |
There was a problem hiding this comment.
Bug: The uv.lock file was not updated with the new Python version requirement. This will cause the Docker build to fail when uv sync --frozen is run.
Severity: CRITICAL
Suggested Fix
Regenerate the uv.lock file to reflect the new Python version requirement specified in pyproject.toml. This can be done by running uv lock and committing the updated uv.lock file.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L6
Potential issue: The `pyproject.toml` file was updated to require Python
`>=3.14.3,<3.15`, but the `uv.lock` file was not regenerated and still enforces the old
requirement of `requires-python = ">=3.13.7, <3.14"`. The production Docker container is
built using a `python:3.14.3` base image. During the Docker build process, the command
`uv sync --frozen` is executed. This command will fail because the container's Python
version (3.14.3) does not satisfy the constraint (`<3.14`) specified in the `uv.lock`
file, which will prevent the application from being deployed.
| description = "AI applications for MIT Open Learning." | ||
| authors = [{ name = "MIT ODL" }] | ||
| requires-python = ">=3.13.7,<3.14" | ||
| requires-python = ">=3.14.3,<3.15" |
There was a problem hiding this comment.
Bug: The CI workflow in .github/workflows/ci.yml is hardcoded to install Python 3.13, but project dependencies now require Python 3.14.3, which will cause CI builds to fail.
Severity: CRITICAL
Suggested Fix
Update the CI workflow file at .github/workflows/ci.yml. Change the Python installation step from run: uv python install 3.13 to run: uv python install 3.14 to match the new version specified in the project's configuration files.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L6
Potential issue: The project's Python version has been updated to `3.14.3` in
`pyproject.toml` and the `uv.lock` file was regenerated accordingly, requiring Python
`>=3.14.3`. However, the CI workflow at `.github/workflows/ci.yml` contains a step that
hardcodes the installation of Python `3.13`. When the CI pipeline runs, it will install
the wrong Python version, causing the `uv sync --locked` command to fail due to a
version mismatch. This will block all builds and prevent the pull request from being
merged.
| description = "AI applications for MIT Open Learning." | ||
| authors = [{ name = "MIT ODL" }] | ||
| requires-python = ">=3.13.7,<3.14" | ||
| requires-python = ">=3.14.3,<3.15" |
There was a problem hiding this comment.
Bug: The CI workflow installs Python 3.13, but the project now requires Python 3.14.3. This will cause the uv sync --locked step to fail.
Severity: CRITICAL
Suggested Fix
In .github/workflows/ci.yml, update the Python installation step to use the correct version. Change the line run: uv python install 3.13 to run: uv python install 3.14.3 to match the project's updated requirements.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L6
Potential issue: The pull request updates the project's Python requirement to version
`3.14.3` in files like `pyproject.toml` and `uv.lock`. However, the CI workflow
configuration in `.github/workflows/ci.yml` was not updated and continues to install
Python `3.13`. When the `uv sync --locked` command runs in the CI pipeline, it will
detect that the installed Python version (`3.13`) does not meet the lock file's
requirement of `requires-python = ">=3.14.3,<3.15"`. This mismatch will cause the `uv
sync` command to fail, breaking the CI pipeline for all future commits.
| description = "AI applications for MIT Open Learning." | ||
| authors = [{ name = "MIT ODL" }] | ||
| requires-python = ">=3.13.7,<3.14" | ||
| requires-python = ">=3.14.3,<3.15" |
There was a problem hiding this comment.
Bug: The CI workflow hardcodes the installation of Python 3.13, but pyproject.toml now requires Python 3.14.3. This will cause the uv sync step to fail.
Severity: CRITICAL
Suggested Fix
Update the CI workflow file .github/workflows/ci.yml to install the correct Python version. Change the step run: uv python install 3.13 to run: uv python install 3.14 or simply run: uv python install, which will respect the .python-version file.
Prompt for AI Agent
Review the code at the location below. A potential bug has been identified by an AI
agent.
Verify if this is a real issue. If it is, propose a fix; if not, explain why it's not
valid.
Location: pyproject.toml#L6
Potential issue: The pull request updates the project's Python requirement to version
3.14.3 in `pyproject.toml`. However, the CI workflow in `.github/workflows/ci.yml` is
not updated and continues to explicitly install Python 3.13 using `uv python install
3.13`. When the `uv sync --locked` command runs, it will detect that the installed
Python version (3.13) is incompatible with the project's `requires-python` constraint
(`>=3.14.3,<3.15`). This mismatch will cause the `uv sync` step to fail, breaking the
entire CI pipeline and preventing any tests from running.
|
This PR contains the following updates:
3.13.7→3.14.33.14.4>=3.13.7,<3.14→>=3.14.4,<3.153.13.7→3.14.33.14.4Release Notes
python/cpython (python)
v3.14.4Compare Source
v3.14.3Compare Source
v3.14.2Compare Source
v3.14.1Compare Source
v3.14.0Compare Source
Configuration
📅 Schedule: (in timezone US/Eastern)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
👻 Immortal: This PR will be recreated if closed unmerged. Get config help if that's undesired.
This PR was generated by Mend Renovate. View the repository job log.