Add macOS with Apple Silicon support - #5
Merged
Conversation
ainame
force-pushed
the
ai/apple-silicon
branch
3 times, most recently
from
June 18, 2025 16:16
a3a76b7 to
6cbaaa0
Compare
ainame
marked this pull request as ready for review
June 18, 2025 16:36
Author
|
Compared contents in pHash-0.9.6.tar.gz before and after. Only config.guess is reverted. Unused index.html?p=config.git was included previously as well. |
ainame
commented
Jun 19, 2025
| # https://github.com/westonplatter/phashion/pull/99 | ||
| if mac_os_with_homebrew | ||
| prefix = `brew --prefix`.strip | ||
| sqlite_prefix = `brew --prefix sqlite3`.strip |
Author
There was a problem hiding this comment.
sqlite3 in homebrew is "keg-only" formula meaning you can't find sliqte3ext.h at /opt/homebrew/include. Instead it only exists at /opt/homebrew/opt/sqlite/include.
kohbis
approved these changes
Jun 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
I created this PR to this fork instead of upstream that's not likely to merge PRs like westonplatter#96, westonplatter#99 and westonplatter#100 and release a new version anytime soon.
I fixed extconf.rb as per the title for modern macOS support.
What's changed?
This PR has two parts -
Approach for config.sub/guess
When I was working on this fix, I didn't realise there is #2 got merged already. Because I still got the error like this below.
This PR title says config.sub and guess were updated but it looks like only
config.guesswas updated.I went with different approach that we keep the original tar ball but overwrite config.sub/guess in extconf.rb. You can see the changes without
tar -xvfand it will be easier to updatepHash's version. Does this approach make sense? Let me know. I can change to the original approach squeezing config.sub/guess files to the tar ball.Testing