Skip to content

Added tensorflow (<2) dependency in setup.py#222

Open
HitLuca wants to merge 2 commits into
minimaxir:masterfrom
HitLuca:master
Open

Added tensorflow (<2) dependency in setup.py#222
HitLuca wants to merge 2 commits into
minimaxir:masterfrom
HitLuca:master

Conversation

@HitLuca

@HitLuca HitLuca commented Jul 22, 2020

Copy link
Copy Markdown

Closes #221

@kousu

kousu commented Aug 9, 2020

Copy link
Copy Markdown

This implicitly pins python<=3.6. Maybe this needs a second change to mark that?

$ python --version
Python 3.8.0
$ pip install 'tensorflow<2'
ERROR: Could not find a version that satisfies the requirement tensorflow<2 (from versions: 2.2.0rc1, 2.2.0rc2, 2.2.0rc3, 2.2.0rc4, 2.2.0, 2.3.0rc0, 2.3.0rc1, 2.3.0rc2, 2.3.0)
ERROR: No matching distribution found for tensorflow<2

@HitLuca

HitLuca commented Aug 28, 2020

Copy link
Copy Markdown
Author

I can confirm that we would need python to be pinned to <=3.6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

setup.py is missing tensorflow dependency

4 participants