Allowing non-fixed length generation (again)#199
Open
dhlanm wants to merge 10 commits into
Open
Conversation
added 10 commits
April 13, 2020 22:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wanted to use #87 for a project, but had to make a lot of changes to it.
Same structure as that PR using the
split_contextvariable. I've tested this a good amount with different batch sizes and split contexts.It might generate infinitely if no length limit is given and the truncation token is never generated. This seems pretty unlikely, but a default length limit could be in order.
You can see a version of this working here :)
Should close #2
(sorry about the slightly messy commits!)