Prevent stop marker from mutating OpenAI-compatible prompts - #842
Open
jxnding wants to merge 1 commit into
Open
Conversation
jxnding
marked this pull request as ready for review
August 18, 2026 20:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
sendRequestpreviously ranstrictFormat(turns)and appendedstop_seqbefore choosing an API path. Both operations mutate the message objects. When a custom URL selectedchat.completions, that branch reused the same turns, so the stop marker was sent inside the prompt as well as in thestoprequest option.Some OpenAI-compatible servers can interpret a stop marker already present in the prompt as an immediate stop and return an empty completion. The mutation also leaked back into Mindcraft's conversation history and could accumulate across retries.
Fix
Clone messages before passing them to
strictFormat, and append the prompt stop marker only in the Responses API branch. Custom endpoints continue to receive the existingstopoption, while their message content remains clean.Validation
npm teston Node 18.20.8, 20.20.2, and 22.23.2