[maxHeight] Expose maxWidth/maxHeight layer constraints in LayerInfo - #525
Open
bcostdolby wants to merge 1 commit into
Open
[maxHeight] Expose maxWidth/maxHeight layer constraints in LayerInfo#525bcostdolby wants to merge 1 commit into
bcostdolby wants to merge 1 commit into
Conversation
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
🦋 Changeset detectedLatest commit: f64b0de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server already honours
layer.maxWidth/layer.maxHeighton theselectandprojectsignaling commands (it maps them tosetMaximumDimensions()), andView.select()/View.project()/View.connect({ layer })forward the layer object verbatim — so this works at runtime today, but the publicLayerInfotype only declared the encoding/spatial/temporal ids, so TS consumers were rejected and no one could discover the feature. This PR is documentation + typings only; no runtime change, and nothing in the SDK strips or validates unknown layer fields (verified inView.jsandSignaling.js, which passlayer/mappingstraight through tosignaling.cmd).The semantic point worth capturing for consumers (and the reason this matters for multiview): the two kinds of layer fields behave very differently.
Naming matches the native SDKs (
LayerDataSelection.withConstraints()on Android,initWithMaxSpatialLayerId:maxTemporalLayerId:maxWidth:maxHeight:on iOS) so the platforms stay consistent.Generated
dist/millicast.d.tspicks the fields up fromsrc/types/index.d.tsvia the normal build; lint,tsc --noEmit, unit tests (29 suites / 173 tests) andnpm run buildpass inpackages/millicast-sdk.Jira: https://opentelly.atlassian.net/browse/OPTI-4136 (epic: https://opentelly.atlassian.net/browse/OPTI-4113)
Link to Devin session: https://dolby.devinenterprise.com/sessions/6e4f2fcc6cea412da1d3c06714c2a817
Requested by: @bcostdolby