Skip to content

Tier-maker: duplicate items and correct CSS when you dropLeave #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlexDG84 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Tier-maker: duplicate items and correct CSS when you dropLeave #54

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2ef3160
Tier-maker: duplicate items and correct CSS Fix when you drop
AlexDG84 Aug 12, 2024
650411b
Apply suggestions from code review
AlexDG84 Aug 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions 07-tier-maker/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,7 @@
}

function useFilesToCreateItems(files) {
if (draggedElement) return
if (files && files.length > 0) {
Array.from(files).forEach(file => {
const reader = new FileReader()
Expand Down Expand Up @@ -217,7 +218,7 @@

if (dataTransfer.types.includes('Files')) {
currentTarget.classList.add('drag-files')
}
}
Comment thread
AlexDG84 marked this conversation as resolved.
Outdated
}

function handleDropFromDesktop(event) {
Expand All @@ -228,7 +229,7 @@
currentTarget.classList.remove('drag-files')
const { files } = dataTransfer
useFilesToCreateItems(files)
}
}
Comment thread
AlexDG84 marked this conversation as resolved.
Outdated
}

function handleDrop(event) {
Expand Down Expand Up @@ -272,6 +273,7 @@

const { currentTarget } = event
currentTarget.classList.remove('drag-over')
currentTarget.classList.remove('drag-files');
Comment thread
AlexDG84 marked this conversation as resolved.
Outdated
currentTarget.querySelector('.drag-preview')?.remove()
}

Expand Down