Skip to content

chore: remove misleading Node 10 TODO comments#2592

Open
ConnorQi01 wants to merge 2 commits intomasterfrom
dev/v-peq/removeNode10TodoComments
Open

chore: remove misleading Node 10 TODO comments#2592
ConnorQi01 wants to merge 2 commits intomasterfrom
dev/v-peq/removeNode10TodoComments

Conversation

@ConnorQi01
Copy link
Copy Markdown
Collaborator

@ConnorQi01 ConnorQi01 commented Apr 10, 2026

Summary

  • Replace TODO comment in appWorker.ts (WORKER_BOOTSTRAP string) with an explanation
    that the polyfill is required because the code runs in the user's RN environment where
    import/require are unavailable.
  • Replace TODO comment in forkedAppWorker.ts with an explanation that the simple
    file:// string concatenation is intentionally kept to avoid URL encoding side-effects
    from url.pathToFileURL().

Files changed

  • src/debugger/appWorker.ts
  • src/debugger/forkedAppWorker.ts

Test plan

  • Run gulp build — no errors
  • Verify no functional behavior changed (comments only)

@ConnorQi01
Copy link
Copy Markdown
Collaborator Author

/azp run

@azure-pipelines
Copy link
Copy Markdown

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant