Skip to content

Handle SQL formatter parse failures #22540

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
caohai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Handle SQL formatter parse failures #22540

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
013b90d
Handle SQL formatter parse failures
caohai Jul 24, 2026
902a92a
Address formatter notification feedback
caohai Jul 25, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions extensions/mssql/l10n/bundle.l10n.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2150,6 +2150,8 @@
},
"View known issues": "View known issues",
"Service installation failed.": "Service installation failed.",
"SQL formatting could not be completed because the T-SQL could not be fully parsed. If you believe the syntax is valid, please send feedback.": "SQL formatting could not be completed because the T-SQL could not be fully parsed. If you believe the syntax is valid, please send feedback.",
"Send Feedback": "Send Feedback",
"Azure sign in failed.": "Azure sign in failed.",
"Select subscriptions": "Select subscriptions",
"Error loading Azure subscriptions.": "Error loading Azure subscriptions.",
Expand Down
74 changes: 40 additions & 34 deletions extensions/mssql/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2428,9 +2428,15 @@
"default": true,
"scope": "window"
},
"mssql.format.showParseErrorNotification": {
"type": "boolean",
"description": "%mssql.format.showParseErrorNotification%",
"default": true,
"scope": "window"
},
"mssql.format.options.sqlVersion": {
"type": "string",
"description": "%mssql.format.options.sqlVersion%",
"markdownDescription": "%mssql.format.options.sqlVersion%",
"default": "sql170",
"enum": [
"sql80",
Expand All @@ -2448,7 +2454,7 @@
},
"mssql.format.options.sqlEngineType": {
"type": "string",
"description": "%mssql.format.options.sqlEngineType%",
"markdownDescription": "%mssql.format.options.sqlEngineType%",
"default": "all",
"enum": [
"all",
Expand All @@ -2459,43 +2465,43 @@
},
"mssql.format.options.alignClauseBodies": {
"type": "boolean",
"description": "%mssql.format.options.alignClauseBodies%",
"markdownDescription": "%mssql.format.options.alignClauseBodies%",
"default": true,
"scope": "window"
},
"mssql.format.options.alignColumnDefinitionFields": {
"type": "boolean",
"description": "%mssql.format.options.alignColumnDefinitionFields%",
"markdownDescription": "%mssql.format.options.alignColumnDefinitionFields%",
"default": true,
"scope": "window"
},
"mssql.format.options.alignSetClauseItem": {
"type": "boolean",
"description": "%mssql.format.options.alignSetClauseItem%",
"markdownDescription": "%mssql.format.options.alignSetClauseItem%",
"default": true,
"scope": "window"
},
"mssql.format.options.allowExternalLanguagePaths": {
"type": "boolean",
"description": "%mssql.format.options.allowExternalLanguagePaths%",
"markdownDescription": "%mssql.format.options.allowExternalLanguagePaths%",
"default": true,
"scope": "window"
},
"mssql.format.options.allowExternalLibraryPaths": {
"type": "boolean",
"description": "%mssql.format.options.allowExternalLibraryPaths%",
"markdownDescription": "%mssql.format.options.allowExternalLibraryPaths%",
"default": true,
"scope": "window"
},
"mssql.format.options.asKeywordOnOwnLine": {
"type": "boolean",
"description": "%mssql.format.options.asKeywordOnOwnLine%",
"markdownDescription": "%mssql.format.options.asKeywordOnOwnLine%",
"default": true,
"scope": "window"
},
"mssql.format.options.keywordCasing": {
"type": "string",
"description": "%mssql.format.options.keywordCasing%",
"markdownDescription": "%mssql.format.options.keywordCasing%",
"default": "uppercase",
"enum": [
"uppercase",
Expand All @@ -2506,153 +2512,153 @@
},
"mssql.format.options.preserveComments": {
"type": "boolean",
"description": "%mssql.format.options.preserveComments%",
"markdownDescription": "%mssql.format.options.preserveComments%",
"default": true,
"scope": "window"
},
"mssql.format.options.indentSetClause": {
"type": "boolean",
"description": "%mssql.format.options.indentSetClause%",
"markdownDescription": "%mssql.format.options.indentSetClause%",
"default": false,
"scope": "window"
},
"mssql.format.options.indentViewBody": {
"type": "boolean",
"description": "%mssql.format.options.indentViewBody%",
"markdownDescription": "%mssql.format.options.indentViewBody%",
"default": false,
"scope": "window"
},
"mssql.format.options.multilineInsertSourcesList": {
"type": "boolean",
"description": "%mssql.format.options.multilineInsertSourcesList%",
"markdownDescription": "%mssql.format.options.multilineInsertSourcesList%",
"default": true,
"scope": "window"
},
"mssql.format.options.multilineInsertTargetsList": {
"type": "boolean",
"description": "%mssql.format.options.multilineInsertTargetsList%",
"markdownDescription": "%mssql.format.options.multilineInsertTargetsList%",
"default": true,
"scope": "window"
},
"mssql.format.options.multilineSelectElementsList": {
"type": "boolean",
"description": "%mssql.format.options.multilineSelectElementsList%",
"markdownDescription": "%mssql.format.options.multilineSelectElementsList%",
"default": true,
"scope": "window"
},
"mssql.format.options.multilineSetClauseItems": {
"type": "boolean",
"description": "%mssql.format.options.multilineSetClauseItems%",
"markdownDescription": "%mssql.format.options.multilineSetClauseItems%",
"default": true,
"scope": "window"
},
"mssql.format.options.multilineViewColumnsList": {
"type": "boolean",
"description": "%mssql.format.options.multilineViewColumnsList%",
"markdownDescription": "%mssql.format.options.multilineViewColumnsList%",
"default": true,
"scope": "window"
},
"mssql.format.options.multilineWherePredicatesList": {
"type": "boolean",
"description": "%mssql.format.options.multilineWherePredicatesList%",
"markdownDescription": "%mssql.format.options.multilineWherePredicatesList%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeCloseParenthesisInMultilineList": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeCloseParenthesisInMultilineList%",
"markdownDescription": "%mssql.format.options.newLineBeforeCloseParenthesisInMultilineList%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeFromClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeFromClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeFromClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeGroupByClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeGroupByClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeGroupByClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeHavingClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeHavingClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeHavingClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeJoinClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeJoinClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeJoinClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeOffsetClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeOffsetClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeOffsetClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeOpenParenthesisInMultilineList": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeOpenParenthesisInMultilineList%",
"markdownDescription": "%mssql.format.options.newLineBeforeOpenParenthesisInMultilineList%",
"default": false,
"scope": "window"
},
"mssql.format.options.newLineBeforeOrderByClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeOrderByClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeOrderByClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeOutputClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeOutputClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeOutputClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeWhereClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeWhereClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeWhereClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newLineBeforeWindowClause": {
"type": "boolean",
"description": "%mssql.format.options.newLineBeforeWindowClause%",
"markdownDescription": "%mssql.format.options.newLineBeforeWindowClause%",
"default": true,
"scope": "window"
},
"mssql.format.options.newlineFormattedCheckConstraint": {
"type": "boolean",
"description": "%mssql.format.options.newlineFormattedCheckConstraint%",
"markdownDescription": "%mssql.format.options.newlineFormattedCheckConstraint%",
"default": false,
"scope": "window"
},
"mssql.format.options.newLineFormattedIndexDefinition": {
"type": "boolean",
"description": "%mssql.format.options.newLineFormattedIndexDefinition%",
"markdownDescription": "%mssql.format.options.newLineFormattedIndexDefinition%",
"default": false,
"scope": "window"
},
"mssql.format.options.numNewlinesAfterStatement": {
"type": "integer",
"description": "%mssql.format.options.numNewlinesAfterStatement%",
"markdownDescription": "%mssql.format.options.numNewlinesAfterStatement%",
"default": 1,
"minimum": 0,
"maximum": 5,
"scope": "window"
},
"mssql.format.options.spaceBetweenDataTypeAndParameters": {
"type": "boolean",
"description": "%mssql.format.options.spaceBetweenDataTypeAndParameters%",
"markdownDescription": "%mssql.format.options.spaceBetweenDataTypeAndParameters%",
"default": true,
"scope": "window"
},
"mssql.format.options.spaceBetweenParametersInDataType": {
"type": "boolean",
"description": "%mssql.format.options.spaceBetweenParametersInDataType%",
"markdownDescription": "%mssql.format.options.spaceBetweenParametersInDataType%",
"default": true,
"scope": "window"
},
Expand Down
Loading
Loading