Skip to content

Upgrade Log4cxx to 1.7.0#51048

Merged
BillyONeal merged 4 commits intomicrosoft:masterfrom
swebb2066:upgrade_log4cxx_to_1_7_0
Apr 9, 2026
Merged

Upgrade Log4cxx to 1.7.0#51048
BillyONeal merged 4 commits intomicrosoft:masterfrom
swebb2066:upgrade_log4cxx_to_1_7_0

Conversation

@swebb2066
Copy link
Copy Markdown
Contributor

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@BillyONeal
Copy link
Copy Markdown
Member

BillyONeal commented Apr 9, 2026

Do we need to do anything to make sure it chooses Qt6 if they are both installed?

e.g. https://github.com/apache/logging-log4cxx/blob/ba4b84682daeec1b50482d7d97c9227ae96be9be/src/main/cpp-qt/CMakeLists.txt#L19

(It's possible/likely that the answer is no, I just want to confirm)

@swebb2066
Copy link
Copy Markdown
Contributor Author

Do we need to do anything to make sure it chooses Qt6 if they are both installed?

Not as far as I know. The result of find_package(QT NAMES Qt6 Qt5 REQUIRED COMPONENTS Core) in ${QT_VERSION_MAJOR} can only have one value, and that is the version that will be used.

@BillyONeal
Copy link
Copy Markdown
Member

Ah, so technically we needed to patch it for the old world order but in the new world order things are fine because they put qt6 first and we ensure that qt6 is there.

Thanks!

@BillyONeal BillyONeal merged commit a2d4473 into microsoft:master Apr 9, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants