Skip to content

[babl] Add native msvc support#50922

Draft
talregev wants to merge 1 commit intomicrosoft:masterfrom
talregev:TalR/babl/msvc
Draft

[babl] Add native msvc support#50922
talregev wants to merge 1 commit intomicrosoft:masterfrom
talregev:TalR/babl/msvc

Conversation

@talregev
Copy link
Copy Markdown
Contributor

@talregev talregev commented Apr 2, 2026

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@talregev talregev force-pushed the TalR/babl/msvc branch 7 times, most recently from 606ba5b to c72a6a0 Compare April 3, 2026 01:10
@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 3, 2026

@talregev talregev force-pushed the TalR/babl/msvc branch 3 times, most recently from 5899b7e to 67556d9 Compare April 3, 2026 10:59
@talregev talregev changed the title [babl] Add msvc support [babl] Add native msvc support Apr 4, 2026
@talregev talregev marked this pull request as ready for review April 4, 2026 14:06
@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 4, 2026

Upstream approve and merge my patch 🥳

@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Apr 5, 2026

Yeah, more mallocs for free!

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 5, 2026

Yeah, more mallocs for free!

I know you can do it better!

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 8, 2026

@vicroms
My PR is ready for review

@vicroms
Copy link
Copy Markdown
Member

vicroms commented Apr 8, 2026

These are too many product code patches, now that they have been merged upstream, perhaps we should wait for an upstream release with them included.

@vicroms vicroms added the requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. label Apr 8, 2026
@vicroms vicroms marked this pull request as draft April 8, 2026 07:37
@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 8, 2026

@brunvonlope FYI
Can you release a new version of babl, that I will update and create a msvc support?

@brunvonlope
Copy link
Copy Markdown
Contributor

Can you release a new version of babl, that I will update and create a msvc support?

@talregev I can't tag a commit on babl/gegl repos because I'm not the maintainer. I will ask to the maintainer anyway since we are close to release gimp 3.2.4 but no promises 😅

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 8, 2026

I will ask to the maintainer anyway since we are close to release gimp 3.2.4 but no promises

The same also for gegl 🙈

@brunvonlope
Copy link
Copy Markdown
Contributor

Done: https://gitlab.gnome.org/GNOME/gimp/-/issues/16193#note_2728943

From my experience observing babl/gegl releases, I suggest to not hold your breath and merge this as it is for now, them the patches can be removed when the new versions came out

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 8, 2026

Done: https://gitlab.gnome.org/GNOME/gimp/-/issues/16193#note_2728943

From my experience observing babl/gegl releases, I suggest to not hold your breath and merge this as it is for now, them the patches can be removed when the new versions came out

It not depend on me. The official vcpkg respond for this PR (babl) is wait for babl release.

@talregev
Copy link
Copy Markdown
Contributor Author

talregev commented Apr 8, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants