Draft
Conversation
19b631b to
e74653e
Compare
BillyONeal
reviewed
Mar 28, 2026
7b79a9c to
f0f98fb
Compare
On Windows static builds, compat/removed_api.cpp emits strong symbol definitions for deprecated APIs. If consumers compile with a higher QT_DISABLE_DEPRECATED_BEFORE value, those same functions become inline definitions in consumer translation units, causing LNK2005 duplicate symbol errors. Fix this in qtcoreexports.h (generated from cmake/modulecppexports.h.in) by adding a dedicated branch for static consumers that always makes QT_CORE_INLINE_SINCE, QT_CONSTEXPR_INLINE_SINCE and QT_CORE_INLINE_IMPL_SINCE produce non-inline.
7 tasks
Contributor
Author
|
After rebasing this PR over #50859, all the CI checks are passing without the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner-Projectform.vcpkg.json, or explicitly disabled through patches or build system arguments such as CMAKE_DISABLE_FIND_PACKAGE_Xxx or VCPKG_LOCK_FIND_PACKAGEvcpkg.jsonmatches what upstream says.vcpkg.jsonmatches what upstream says../vcpkg x-add-version --alland committing the result.