Skip to content

[taocpp-json] Update to 1.0.0-beta.14#50375

Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom
kiwixz:tao
Mar 11, 2026
Merged

[taocpp-json] Update to 1.0.0-beta.14#50375
JavierMatosD merged 1 commit intomicrosoft:masterfrom
kiwixz:tao

Conversation

@kiwixz
Copy link
Copy Markdown
Contributor

@kiwixz kiwixz commented Mar 9, 2026

No releases are available yet, so I just picked the latest beta.

This notably fixes the following a GCC>=15 warning caused by tao/json/external/pegtl/demangle.hpp:7:

/usr/include/c++/15/ciso646:49:6: warning: #warning "<ciso646> is not a standard header since C++20, use <version> to detect implementation-specific macros" [-Wcpp]
   49 | #    warning "<ciso646> is not a standard header since C++20, use <version> to detect implementation-specific macros"
      |      ^~~~~~~

Followed advice from #27004 (comment) to include the new submodule, PEGTL was previously vendored.

Tested on Linux x64 with a small example.

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

Comment thread ports/taocpp-json/portfile.cmake Outdated
# grab the submodule
vcpkg_from_github(
OUT_SOURCE_PATH PEGTL_SOURCE_PATH
REPO taocpp/pegtl
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to not use a vendored copy of that library and use the one from https://github.com/microsoft/vcpkg/tree/master/ports/pegtl instead.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternately, the port doesn't seem to install anything from here and it is header only; is this change needed at all?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did look for PEGTL in vcpkg but not hard enough it seems, would have saved me some work!

The CMakeLists.txt of the json library tries to find_package PEGTL and otherwise add_subdirectory the submodule, so the dependency is needed (and probably a good idea anyway so it "just works").

Copy link
Copy Markdown
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! (Will merge if build works out)

@JavierMatosD JavierMatosD merged commit 2d856f7 into microsoft:master Mar 11, 2026
16 checks passed
@kiwixz kiwixz deleted the tao branch March 19, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants