[taocpp-json] Update to 1.0.0-beta.14#50375
Merged
JavierMatosD merged 1 commit intomicrosoft:masterfrom Mar 11, 2026
Merged
Conversation
BillyONeal
reviewed
Mar 9, 2026
| # grab the submodule | ||
| vcpkg_from_github( | ||
| OUT_SOURCE_PATH PEGTL_SOURCE_PATH | ||
| REPO taocpp/pegtl |
Member
There was a problem hiding this comment.
This needs to not use a vendored copy of that library and use the one from https://github.com/microsoft/vcpkg/tree/master/ports/pegtl instead.
Member
There was a problem hiding this comment.
Alternately, the port doesn't seem to install anything from here and it is header only; is this change needed at all?
Contributor
Author
There was a problem hiding this comment.
I did look for PEGTL in vcpkg but not hard enough it seems, would have saved me some work!
The CMakeLists.txt of the json library tries to find_package PEGTL and otherwise add_subdirectory the submodule, so the dependency is needed (and probably a good idea anyway so it "just works").
BillyONeal
approved these changes
Mar 9, 2026
Member
BillyONeal
left a comment
There was a problem hiding this comment.
Thanks! (Will merge if build works out)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No releases are available yet, so I just picked the latest beta.
This notably fixes the following a GCC>=15 warning caused by
tao/json/external/pegtl/demangle.hpp:7:Followed advice from #27004 (comment) to include the new submodule, PEGTL was previously vendored.
Tested on Linux x64 with a small example.
./vcpkg x-add-version --alland committing the result.