Skip to content

Update libpq to version 18.3#50345

Merged
vicroms merged 28 commits intomicrosoft:masterfrom
frankhale:libpq-18.3
Mar 25, 2026
Merged

Update libpq to version 18.3#50345
vicroms merged 28 commits intomicrosoft:masterfrom
frankhale:libpq-18.3

Conversation

@frankhale
Copy link
Copy Markdown
Contributor

@frankhale frankhale commented Mar 7, 2026

Update libpq to version 18.3. This has been tested on MacOS 26.3.1 and Arm64 Linux

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version, or no changes were necessary.
  • Any fixed CI baseline and CI feature baseline entries are removed from that file, or no entries needed to be changed.
  • All patch files in the port are applied and succeed.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Exactly one version is added in each modified versions file.

@frankhale frankhale marked this pull request as draft March 7, 2026 17:16
Comment thread ports/libpq/portfile.cmake Outdated
Comment thread ports/libpq/windows/macro-def.patch
Comment thread ports/libpq/unix/mingw-static-importlib-fix.patch Outdated
Comment thread ports/libpq/unix/installdirs.patch Outdated
Comment thread ports/libpq/unix/installdirs.patch Outdated
Comment thread ports/libpq/unix/installdirs.patch Outdated
Comment thread ports/libpq/unix/installdirs.patch Outdated
Comment thread ports/libpq/unix/installdirs.patch Outdated
@dg0yt
Copy link
Copy Markdown
Contributor

dg0yt commented Mar 8, 2026

Is it necessary to replace the msbuild stuff?

@frankhale
Copy link
Copy Markdown
Contributor Author

Is it necessary to replace the msbuild stuff?

it was replaced because PG18 uses Meson

Comment thread ports/libpq/build-msvc.cmake
Comment thread ports/libpq/build-msvc.cmake
Comment thread ports/libpq/build-msvc.cmake
Comment thread ports/libpq/build-msvc.cmake
@frankhale frankhale marked this pull request as ready for review March 9, 2026 23:44
BillyONeal and others added 2 commits March 9, 2026 17:26
```
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:706:7: error: libpq[core,python]:arm64-linux passed but libpq[python] was marked expected to be a cascaded failure
/vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:705:7: error: libpq[core,all]:arm64-linux passed but libpq[all] was marked expected to be a cascaded failure
```
Fix "passed but was marked expected to be a cascaded failure"
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A PR can add only one new version entry for a port. Here, it is libpq 18.3 port-version 0.

After applying the suggestions to the ports/libpq diretroy, the git-tree referenence will change. Run this command to update the entry which is already part of the PR:

vcpkg x-add-version --overwrite-version libpq

Comment thread ports/libpq/vcpkg.json Outdated
"version": "16.9",
"port-version": 3,
"version": "18.3",
"port-version": 17,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"port-version": 17,

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it took 17 attempts to get all CI builds complete. I am not sure what the process is but this should ultimately be 1. When making the changes to fix the builds vcpkg complained to me that I had to update the version so that is why it is now at 17.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know why you did it... I didn't blame you.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for mentioning how to reset the version. I appreciate that!

Comment thread versions/l-/libpq.json
Comment thread versions/baseline.json Outdated
Copy link
Copy Markdown
Contributor

@dg0yt dg0yt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is still using autotools for !windows, but meson for windows?
IMO meson should be used for all targets if supported by upstream.

Comment thread ports/libpq/unix/fix-configure.patch Outdated
Comment thread ports/libpq/unix/installdirs.patch Outdated
Comment thread versions/l-/libpq.json
@vicroms vicroms marked this pull request as draft March 13, 2026 06:47
@vicroms vicroms closed this Mar 13, 2026
@vicroms vicroms reopened this Mar 13, 2026
@frankhale frankhale requested a review from vicroms March 18, 2026 17:30
@frankhale frankhale marked this pull request as ready for review March 20, 2026 15:35
@frankhale
Copy link
Copy Markdown
Contributor Author

This is a big PR (a lot of changes) and I know your time is limited with the amount of other PRs getting submitted each day. If anyone is available to review this and has feedback and/or changes that need to be made please let me know. I'd like to get this one merged so I can submit a libpqxx port upgrade to go along with this one. Thank you!

@vicroms vicroms merged commit 717e7d7 into microsoft:master Mar 25, 2026
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants