Update libpq to version 18.3#50345
Conversation
|
Is it necessary to replace the msbuild stuff? |
it was replaced because PG18 uses Meson |
``` /vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:706:7: error: libpq[core,python]:arm64-linux passed but libpq[python] was marked expected to be a cascaded failure /vcpkg/scripts/azure-pipelines/../ci.feature.baseline.txt:705:7: error: libpq[core,all]:arm64-linux passed but libpq[all] was marked expected to be a cascaded failure ```
Fix "passed but was marked expected to be a cascaded failure"
dg0yt
left a comment
There was a problem hiding this comment.
A PR can add only one new version entry for a port. Here, it is libpq 18.3 port-version 0.
After applying the suggestions to the ports/libpq diretroy, the git-tree referenence will change. Run this command to update the entry which is already part of the PR:
vcpkg x-add-version --overwrite-version libpq
| "version": "16.9", | ||
| "port-version": 3, | ||
| "version": "18.3", | ||
| "port-version": 17, |
There was a problem hiding this comment.
| "port-version": 17, |
There was a problem hiding this comment.
it took 17 attempts to get all CI builds complete. I am not sure what the process is but this should ultimately be 1. When making the changes to fix the builds vcpkg complained to me that I had to update the version so that is why it is now at 17.
There was a problem hiding this comment.
I know why you did it... I didn't blame you.
There was a problem hiding this comment.
Thank you for mentioning how to reset the version. I appreciate that!
dg0yt
left a comment
There was a problem hiding this comment.
It is still using autotools for !windows, but meson for windows?
IMO meson should be used for all targets if supported by upstream.
|
This is a big PR (a lot of changes) and I know your time is limited with the amount of other PRs getting submitted each day. If anyone is available to review this and has feedback and/or changes that need to be made please let me know. I'd like to get this one merged so I can submit a libpqxx port upgrade to go along with this one. Thank you! |
Update libpq to version 18.3. This has been tested on MacOS 26.3.1 and Arm64 Linux
./vcpkg x-add-version --alland committing the result.