Simplify crash dump implementation to not need ITestApplicationModuleInfo#7709
Merged
Youssef1313 merged 1 commit intomainfrom Apr 10, 2026
Merged
Simplify crash dump implementation to not need ITestApplicationModuleInfo#7709Youssef1313 merged 1 commit intomainfrom
Youssef1313 merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the CrashDump extension wiring by removing the dependency on ITestApplicationModuleInfo, and instead derives the default dump filename prefix from the entry assembly name.
Changes:
- Remove
ITestApplicationModuleInfousage fromAddCrashDumpProviderandCrashDumpEnvironmentVariableProvider. - Compute the default crash dump filename pattern using
Assembly.GetEntryAssembly()?.GetName().Name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/Platform/Microsoft.Testing.Extensions.CrashDump/CrashDumpExtensions.cs | Stops passing ITestApplicationModuleInfo into the crash dump environment variable provider. |
| src/Platform/Microsoft.Testing.Extensions.CrashDump/CrashDumpEnvironmentVariableProvider.cs | Removes the module info dependency and builds the default dump filename pattern from the entry assembly name. |
src/Platform/Microsoft.Testing.Extensions.CrashDump/CrashDumpEnvironmentVariableProvider.cs
Show resolved
Hide resolved
Evangelink
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.