Bump MSAL Node to v5#603
Open
heyitsaamir wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Bumps @azure/msal-node from v3 to v5.2.2 in @microsoft/teams.apps to drop the vulnerable transitive uuid dependency, and updates the token-manager test mock to match MSAL v5's fromNativeBroker → fromPlatformBroker rename.
Changes:
- Upgrade
@azure/msal-nodedependency to^5.2.2inpackages/apps/package.json. - Update test mock field name
fromNativeBroker→fromPlatformBrokerintoken-manager.spec.ts. - Refresh
package-lock.jsonto reflect new MSAL v5 / msal-common 16 versions.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/apps/package.json | Bumps @azure/msal-node to ^5.2.2. |
| packages/apps/src/token-manager.spec.ts | Renames mocked field to fromPlatformBroker for MSAL v5 compatibility. |
| package-lock.json | Lockfile updated to MSAL v5.2.2 / msal-common 16.6.2; removes nested uuid dep. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@azure/msal-nodein@microsoft/teams.appsto v5.2.2.fromNativeBroker->fromPlatformBrokerrename.Why
uuiddependency path from@microsoft/teams.apps.Interesting bits
npm auditstill reports the existing BotBuilder/Restify transitive stuff. No spicy force-downgrades today.Testing
npx turbo build --filter=@microsoft/teams.appsnpx turbo test --filter=@microsoft/teams.appsnpx npm@11.12.1 auditstill reports remaining BotBuilder/Restify transitive advisories