Skip to content

Python: fix(python): correct typos in comments and docstrings #14790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ultron (Ultroncn) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Python: fix(python): correct typos in comments and docstrings #14790

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/semantic_kernel/agents/runtime/core/routed_agent.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
ProducesT = TypeVar("ProducesT", covariant=True)

# TODO(evmattso): Generic typevar bound binding U to agent type
# Can't do because python doesnt support it
# Can't do because python doesn't support it

# region MessageHandler Protocol and Methods

Expand Down
4 changes: 2 additions & 2 deletions python/semantic_kernel/connectors/memory_stores/milvus/milvus_memory_store.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -278,7 +278,7 @@ async def upsert_batch(self, collection_name: str, records: list[MemoryRecord],
size of total size. Defaults to 100.

Raises:
Exception: Collection doesnt exist.
Exception: Collection doesn't exist.
e: Failed to upsert a record.

Returns:
Expand Down Expand Up @@ -360,7 +360,7 @@ async def remove_batch(self, collection_name: str, keys: list[str]) -> None:
keys (List[str]): The list of keys.

Raises:
Exception: Collection doesnt exist.
Exception: Collection doesn't exist.
e: Failure to remove key.
"""
if collection_name not in utility.list_collections():
Expand Down
2 changes: 1 addition & 1 deletion python/semantic_kernel/data/vector.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -407,7 +407,7 @@ def __init__(
"""Vector store field."""
self.field_type = field_type if isinstance(field_type, FieldTypes) else FieldTypes(field_type)
# when a field is created, the name can be empty,
# when a field get's added to a definition, the name needs to be there.
# when a field gets added to a definition, the name needs to be there.
if name:
self.name = name
self.storage_name = storage_name
Expand Down
Loading