Skip to content

Python: Merge a streaming item into only one matching item #14787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Muhammad Abdullah Butt (1AbdullahButt) wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Python: Merge a streaming item into only one matching item #14787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions python/semantic_kernel/contents/streaming_content_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def _merge_items_lists(self, other_items: list[Any]) -> list[Any]:
new_item = item + other_item # type: ignore
new_items_list[id] = new_item
added = True
break
except (ValueError, ContentAdditionException) as ex:
logger.debug(f"Could not add item {other_item} to {item}.", exc_info=ex)
continue
Expand Down
16 changes: 16 additions & 0 deletions python/tests/unit/contents/test_streaming_chat_message_content.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,6 +290,22 @@ def test_scmc_add_three():
assert len(combined.inner_content) == 3


def test_scmc_add_merges_item_into_one_matching_item_only():
message1 = StreamingChatMessageContent(
choice_index=0,
role=AuthorRole.ASSISTANT,
items=[
StreamingTextContent(choice_index=0, text="Part one. "),
StreamingTextContent(choice_index=0, text="Part two. "),
],
)
message2 = StreamingChatMessageContent(
choice_index=0, role=AuthorRole.ASSISTANT, items=[StreamingTextContent(choice_index=0, text="tail")]
)
combined = message1 + message2
assert [item.text for item in combined.items] == ["Part one. tail", "Part two. "]


@pytest.mark.parametrize(
"message1, message2",
[
Expand Down
Loading