[Adil Alperen Çiftci (adilalperenciftci)]

Summary

Complex and union annotations containing commas could skip parameter validation in gather_function_parameters, allowing values with the wrong shape to reach the kernel function. PEP 604 unions also needed their original annotation preserved when non-optional type resolution returned no entries.

Changes

• Validate generic and union annotations with Pydantic TypeAdapter.
• Remove the comma-based condition that skipped parsing for complex type metadata.
• Preserve the original union annotation when non-optional type resolution is empty.
• Permit ordinary custom Python classes while retaining rejection of invalid values.
• Add regression coverage for valid and invalid dict[str, int] inputs, invalid union inputs, valid primitive branches, and valid custom-class instances.

Validation

• Focused function suites: 117 passed on Python 3.12.
• Ruff checks and formatting checks pass for all changed files.

[Copilot]

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

[Adil Alperen Çiftci (adilalperenciftci)]

Updated the branch to current main. The focused validation suite passes 43 tests; Ruff check and formatting checks are also clean. Could a maintainer approve the workflows and take a first look at the new head?

[Adil Alperen Çiftci (adilalperenciftci)]

I rebased the branch onto current main and retained the arbitrary-class union regression coverage. The focused function suites pass 115 tests on Python 3.12, and ruff is clean for the changed files. I also resolved the addressed review thread.

[Ammann Labs (agammann)]

Removing the comma guard should validate generic annotations such as dict[str, int], but the new tests only exercise unions. Could the regression suite pass one valid and one invalid value to a function with a dict[str, int] argument? That would cover the previously skipped comma path and the new TypeAdapter branch directly.

[Adil Alperen Çiftci (adilalperenciftci)]

Added the requested valid and invalid dict[str, int] invocation regressions in f678753. The invalid case reproduces the previous comma-path behavior by showing that the function was invoked instead of rejecting the value; the current path raises before invocation. The focused function suites now pass 117 tests on Python 3.12, and Ruff check/format validation is clean.