[do not merge] powershell test#3499
Open
babayet2 wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates Windows PowerShell invocation and CI runner image selection to retry a PowerShell-related test while avoiding runner path issues.
Changes:
- Switch
PowerShellBuilderto invoke PowerShell 7 (pwsh.exe) via an explicit filesystem path. - Update Flowey pool constants and regenerate CI pipeline/workflow YAMLs to use
win-*-pwsh-testrunner images for Windows jobs.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| support/powershell_builder/src/lib.rs | Changes the default PowerShell executable used by the command builder to a fixed pwsh.exe path. |
| flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs | Changes the default Windows 1ES image names to *-pwsh-test. |
| ci-flowey/openvmm-pr.yaml | Regenerated ADO PR pipeline to demand win-amd64-pwsh-test for Windows jobs. |
| .github/workflows/openvmm-pr.yaml | Regenerated GitHub PR workflow to use win-*-pwsh-test image overrides. |
| .github/workflows/openvmm-pr-release.yaml | Regenerated GitHub PR-release workflow to use win-*-pwsh-test image overrides. |
| .github/workflows/openvmm-ci.yaml | Regenerated GitHub CI workflow to use win-*-pwsh-test image overrides. |
Comment on lines
+24
to
26
| PowerShellCmdletBuilder(Command::new("C:\\PROGRA~1\\PowerShell\\7\\pwsh.exe")) | ||
| .flag("NoProfile") | ||
| .finish() |
Comment on lines
+12
to
+13
| pub const WINDOWS_IMAGE_AMD64: &str = "win-amd64-pwsh-test"; | ||
| pub const WINDOWS_IMAGE_ARM64: &str = "win-arm64-pwsh-test"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
retrying Steven's test to eliminate path issues