WIP CI: Use modern pwsh.exe instead of legacy powershell.exe#3493
Open
smalis-msft wants to merge 1 commit into
Open
WIP CI: Use modern pwsh.exe instead of legacy powershell.exe#3493smalis-msft wants to merge 1 commit into
smalis-msft wants to merge 1 commit into
Conversation
smalis-msft
added
the
release-ci-required
Contributor
There was a problem hiding this comment.
Pull request overview
This PR switches OpenVMM’s Windows PowerShell invocation path and Windows CI images toward PowerShell 7 to avoid intermittent powershell.exe startup crashes in Petri-based VMM tests.
Changes:
- Changes
PowerShellBuilderto launchpwsh.exe. - Updates shared Windows runner image constants to
*-pwsh-test. - Regenerates GitHub and ADO workflow YAMLs to use the new Windows image labels.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
support/powershell_builder/src/lib.rs |
Changes the PowerShell executable used by the builder. |
flowey/flowey_hvlite/src/pipelines_shared/gh_pools.rs |
Updates shared Windows CI image labels. |
ci-flowey/openvmm-pr.yaml |
Regenerated ADO PR workflow image demands. |
.github/workflows/openvmm-pr.yaml |
Regenerated GitHub PR workflow runner labels. |
.github/workflows/openvmm-pr-release.yaml |
Regenerated GitHub PR release workflow runner labels. |
.github/workflows/openvmm-ci.yaml |
Regenerated GitHub CI workflow runner labels. |
| /// Create a new PowerShell command | ||
| pub fn new() -> Self { | ||
| PowerShellCmdletBuilder(Command::new("powershell.exe")) | ||
| PowerShellCmdletBuilder(Command::new("pwsh.exe")) |
Comment on lines
+12
to
+13
| pub const WINDOWS_IMAGE_AMD64: &str = "win-amd64-pwsh-test"; | ||
| pub const WINDOWS_IMAGE_ARM64: &str = "win-arm64-pwsh-test"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Petri-based VMM tests intermittently fail on Windows CI runners with
powershell.execrashing during session initialization:Approach
Switch to Powershell 7, which does not use the same logging pipeline, and so will not hit this error.
Alternative to #3457