petri: Plumb EfiDiagnosticsLogLevel and add INFO level test#3481
Open
maheeraeron wants to merge 4 commits into
Open
petri: Plumb EfiDiagnosticsLogLevel and add INFO level test#3481maheeraeron wants to merge 4 commits into
maheeraeron wants to merge 4 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Petri-level configuration for EFI diagnostics verbosity and uses it in a new VMM test that verifies an INFO-level UEFI diagnostics message is observable through OpenHCL kmsg.
Changes:
- Adds
EfiDiagnosticsLogLevelto Petri UEFI configuration and a builder setter. - Maps the Petri log-level enum into OpenVMM and GED configuration paths.
- Adds a multiarch test that enables INFO diagnostics and searches kmsg for a known INFO message.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
petri/src/vm/mod.rs |
Adds the public Petri UEFI diagnostics log-level API and config field. |
petri/src/vm/openvmm/construct.rs |
Plumbs the new Petri setting into OpenVMM and OpenHCL GED config construction. |
vmm_tests/vmm_tests/tests/tests/multiarch.rs |
Adds an OpenVMM/OpenHCL UEFI test for INFO-level EFI diagnostics output. |
chris-oo
approved these changes
May 13, 2026
Member
chris-oo
left a comment
chris-oo
left a comment
There was a problem hiding this comment.
LGTM but question around testing on hyper-v
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small PR to plumb the EfiDiagnosticsLogLevel configuration to Petri, then add a test that searches for a specific INFO level log