Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5892 +/- ##
==========================================
- Coverage 86.23% 85.26% -0.97%
==========================================
Files 60 60
Lines 18732 18731 -1
==========================================
- Hits 16153 15971 -182
- Misses 2579 2760 +181 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
guhetier
left a comment
guhetier
left a comment
There was a problem hiding this comment.
It would be nice to also add a call to StreamProvideReceiveBuffers when a new stream is notified to a connection.
| if (Registration) { | ||
| MsQuic->RegistrationClose(Registration); | ||
| if (rand() % 2 == 0) { | ||
| CXPLAT_EVENT CloseComplete; |
There was a problem hiding this comment.
nit: Consider using a CxPlatEvent since this is C++.
There was a problem hiding this comment.
CxPlatEvent throws an error. I think it requires the CX_PLATFORM_TYPE which comes from the platform headers which we dont include
There was a problem hiding this comment.
I think you just need to include msquic.hpp after msquichelper.h
There was a problem hiding this comment.
That doesnt work either cause it causes name collisions:
C:\Users\gaurasingh\msquic\src\tools\spin\spinquic.cpp(203,23): error C2040: 'MsQuic': 'QUIC_API_TABLE' differs in leve ls of indirection from 'const MsQuicApi *'
msquic.hpp declares extern const MsQuicApi* MsQuic; while spinquic.cpp declares static QUIC_API_TABLE MsQuic. Including msquic.hpp causes a name collision.
3 participants
Description
SpinQuic updated to cover the new/experimental APIs:
ConnectionPoolCreate
RegistrationClose2
App-provided receive buffers APIs: StreamProvideReceiveBuffers_Describe the purpose of and changes within this Pull Request._
Testing
Do any existing tests cover this change? Are new tests needed?
Documentation
Is there any documentation impact for this change?