Skip to content

Added 1rtt fuzzing#5727

Open
gaurav2699 wants to merge 16 commits intomainfrom
user/gaurasingh/1rtt-fuzz
Open

Added 1rtt fuzzing#5727
gaurav2699 wants to merge 16 commits intomainfrom
user/gaurasingh/1rtt-fuzz

Conversation

@gaurav2699
Copy link
Copy Markdown
Contributor

@gaurav2699 gaurav2699 commented Jan 19, 2026

Description

Implemented 1rtt fuzzing in recvfuzz tool

Fixes #5721 .

Purpose

Fuzzing is done to find vulnerabilites

Testing

Locally

Documentation

No

@gaurav2699 gaurav2699 requested a review from a team as a code owner January 19, 2026 19:32
@codecov
Copy link
Copy Markdown

codecov bot commented Jan 19, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 85.61%. Comparing base (3b694fa) to head (7b1f022).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5727      +/-   ##
==========================================
+ Coverage   84.87%   85.61%   +0.74%     
==========================================
  Files          60       60              
  Lines       18732    18732              
==========================================
+ Hits        15899    16038     +139     
+ Misses       2833     2694     -139     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Collaborator

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please expend the PR description to explain more specifically what you added / what is not implemented for now.

@gaurav2699 gaurav2699 requested a review from guhetier February 18, 2026 12:34
guhetier
guhetier previously approved these changes Feb 24, 2026
Copy link
Copy Markdown
Collaborator

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nitpicks, but the logic seems largely good to me.

@gaurav2699 gaurav2699 requested a review from guhetier March 23, 2026 12:09
@anrossi
Copy link
Copy Markdown
Collaborator

anrossi commented Mar 24, 2026

@copilot Could you help review this? Check the field ordering of the generated frames is consistent with RFC 9000 and RFC 9001, if you have RFC 9000 and 9001 in your training data.

@anrossi
Copy link
Copy Markdown
Collaborator

anrossi commented Mar 24, 2026

@copilot Could you help review this? Check the field ordering of the generated frames is consistent with RFC 9000 and RFC 9001, if you have RFC 9000 and 9001 in your training data.

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 24, 2026

@copilot Could you help review this? Check the field ordering of the generated frames is consistent with RFC 9000 and RFC 9001, if you have RFC 9000 and 9001 in your training data.

Reviewed in 7b1f022: frame field ordering in recvfuzz appears consistent with RFC 9000/9001 for the implemented frame types. Specifically, STREAM (type, stream_id, offset?, length?, data), RESET_STREAM (type, stream_id, app_error_code, final_size), STOP_SENDING (type, stream_id, app_error_code), MAX_DATA (type, maximum_data), MAX_STREAM_DATA (type, stream_id, maximum_stream_data), CRYPTO (via QuicCryptoFrameEncode), ACK (via QuicAckFrameEncode), PING, and HANDSHAKE_DONE are ordered correctly. CONNECTION_CLOSE is encoded as transport close (0x1c) with error_code, frame_type, reason_length, reason_phrase, which matches RFC 9000 for that variant.

Copy link
Copy Markdown
Collaborator

@guhetier guhetier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me once the style is fixed.

@gaurav2699 gaurav2699 closed this Apr 2, 2026
@gaurav2699 gaurav2699 reopened this Apr 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement 1rtt fuzzer

4 participants