Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5727 +/- ##
==========================================
+ Coverage 84.87% 85.61% +0.74%
==========================================
Files 60 60
Lines 18732 18732
==========================================
+ Hits 15899 16038 +139
+ Misses 2833 2694 -139 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
…gaurasingh/1rtt-fuzz
guhetier
left a comment
There was a problem hiding this comment.
Please expend the PR description to explain more specifically what you added / what is not implemented for now.
…oft/msquic into user/gaurasingh/1rtt-fuzz
guhetier
left a comment
There was a problem hiding this comment.
Some nitpicks, but the logic seems largely good to me.
…gaurasingh/1rtt-fuzz
|
@copilot Could you help review this? Check the field ordering of the generated frames is consistent with RFC 9000 and RFC 9001, if you have RFC 9000 and 9001 in your training data. |
|
@copilot Could you help review this? Check the field ordering of the generated frames is consistent with RFC 9000 and RFC 9001, if you have RFC 9000 and 9001 in your training data. |
Reviewed in 7b1f022: frame field ordering in recvfuzz appears consistent with RFC 9000/9001 for the implemented frame types. Specifically, STREAM (type, stream_id, offset?, length?, data), RESET_STREAM (type, stream_id, app_error_code, final_size), STOP_SENDING (type, stream_id, app_error_code), MAX_DATA (type, maximum_data), MAX_STREAM_DATA (type, stream_id, maximum_stream_data), CRYPTO (via QuicCryptoFrameEncode), ACK (via QuicAckFrameEncode), PING, and HANDSHAKE_DONE are ordered correctly. CONNECTION_CLOSE is encoded as transport close (0x1c) with error_code, frame_type, reason_length, reason_phrase, which matches RFC 9000 for that variant. |
…gaurasingh/1rtt-fuzz
guhetier
left a comment
There was a problem hiding this comment.
Looks good to me once the style is fixed.
Description
Implemented 1rtt fuzzing in recvfuzz tool
Fixes #5721 .
Purpose
Fuzzing is done to find vulnerabilites
Testing
Locally
Documentation
No