fix: preserve HTML tables in Outlook .msg conversion#1673
Open
octo-patch wants to merge 1 commit intomicrosoft:mainfrom
Open
fix: preserve HTML tables in Outlook .msg conversion#1673octo-patch wants to merge 1 commit intomicrosoft:mainfrom
octo-patch wants to merge 1 commit intomicrosoft:mainfrom
Conversation
…#1567) When a .msg file contains an HTML body (PR_BODY_HTML), prefer it over the plain text body so that tables and other HTML formatting are converted to proper markdown instead of being stripped. - Try Unicode HTML stream (__substg1.0_1013001F) first - Fall back to binary HTML stream (__substg1.0_10130102) - Convert HTML to markdown via BeautifulSoup + _CustomMarkdownify - Fall back to plain text body if no HTML body is present
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1567
Problem
The
OutlookMsgConverterreads only the plain text body, discarding the HTML body. When a .msg file contains HTML tables, the plain text fallback strips all HTML formatting.Solution
Prefer the HTML body (PR_BODY_HTML) when it exists:
__substg1.0_1013001Ffirst__substg1.0_10130102No new dependencies introduced.
Testing
Tested with a .msg file containing HTML tables. Before: unformatted plain text. After: proper markdown tables.