New testcase 'verify_smb_linux' for CIFS module validation#4503
Open
SRIKKANTH wants to merge 11 commits into
Open
New testcase 'verify_smb_linux' for CIFS module validation#4503SRIKKANTH wants to merge 11 commits into
SRIKKANTH wants to merge 11 commits into
Conversation
New testcase 'verify_smb_linux' A test to verify CIFS module and SMB share functionality between two Linux VMs. SMB server and client tools are added which are useful in validating samba file share with Linux OS and CIFS module in kernel.
SRIKKANTH
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Adds an SMB/CIFS validation scenario to the storage test suite and introduces reusable SMB server/client tools for Linux nodes.
Changes:
- Added
SmbServerandSmbClienttools for Samba setup, CIFS mounting, and cleanup. - Added CIFS as a mount filesystem type.
- Added
verify_smb_linux, a two-node Linux test that validates SMB versions and file I/O over a share.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 8 comments.
| File | Description |
|---|---|
lisa/tools/smb.py |
Adds SMB server/client tool implementations. |
lisa/tools/mkfs.py |
Adds cifs to the filesystem enum for mount usage. |
lisa/tools/__init__.py |
Exports the new SMB tools. |
lisa/microsoft/testsuites/core/storage.py |
Adds the SMB Linux validation test case. |
SRIKKANTH
requested review from
umfranci
and removed request for
kanchansenlaskar
❌ AI Test Selection — FAILED74 test case(s) selected (view run) Marketplace image: suse sles-15-sp6 gen2 latest
Test case details
|
LiliDeng
reviewed
Jun 1, 2026
| timeout=TIME_OUT, | ||
| requirement=simple_requirement( | ||
| min_count=2, | ||
| supported_os=[Debian, Ubuntu], |
Collaborator
There was a problem hiding this comment.
supported_os=[Debian], should be enough.
Collaborator
Author
There was a problem hiding this comment.
Fixed as suggeested
LiliDeng
reviewed
Jun 1, 2026
| mount_point = f"/mnt/{share_name}" | ||
|
|
||
| failed_versions: List[str] = [] | ||
| try: |
Collaborator
There was a problem hiding this comment.
This try doesn't have except.
Collaborator
Author
There was a problem hiding this comment.
Fixed as suggeested
❌ AI Test Selection — FAILED74 test case(s) selected (view run) Marketplace image: suse sles-15-sp6 gen2 latest
Test case details
|
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
🤖 AI Test SelectionNo test cases were selected for this PR. |
Comment on lines
+104
to
+106
| self.node.tools[Echo].write_to_file( | ||
| smb_config, PurePosixPath(self.SMB_CONF_FILE), sudo=True | ||
| ) |
…com/microsoft/lisa into smyakam/verify_smb_linux/2026_05_29
|
| Count | |
|---|---|
| ✅ Passed | 18 |
| ❌ Failed | 2 |
| ⏭️ Skipped | 4 |
| Total | 24 |
Test case details
| Test Case | Status | Time (s) | Message |
|---|---|---|---|
| verify_vmbus_devices_channels_bsd (lisa_0_40) | ⏭️ SKIPPED | 0.000 | check skipped: OS type mismatch: ["requires [<class 'lisa.operating_system.BSD'>] but VM supports [<class 'lisa.operatin |
| verify_l3_cache (lisa_0_3) | ✅ PASSED | 0.858 | |
| verify_cpu_count (lisa_0_4) | ✅ PASSED | 8.338 | |
| verify_default_targetpw (lisa_0_43) | ✅ PASSED | 2.926 | |
| verify_grub (lisa_0_44) | ✅ PASSED | 2.276 | |
| verify_network_file_configuration (lisa_0_46) | ⏭️ SKIPPED | 1.480 | skipped: unsupported distro type: <class 'lisa.operating_system.SLES'> |
| verify_ifcfg_eth0 (lisa_0_47) | ⏭️ SKIPPED | 1.362 | skipped: unsupported distro type: <class 'lisa.operating_system.SLES'> |
| verify_udev_rules_moved (lisa_0_48) | ⏭️ SKIPPED | 1.246 | skipped: Unsupported distro type : <class 'lisa.operating_system.SLES'> |
| verify_dhcp_file_configuration (lisa_0_49) | ✅ PASSED | 2.462 | |
| verify_serial_console_is_enabled (lisa_0_54) | ✅ PASSED | 2.744 | |
| verify_no_pre_exist_users (lisa_0_59) | ✅ PASSED | 3.461 | |
| verify_resource_disk_file_system (lisa_0_61) | ✅ PASSED | 5.150 | |
| verify_waagent_version (lisa_0_62) | ✅ PASSED | 1.301 | |
| verify_python_version (lisa_0_63) | ❌ FAILED | 2.135 | failed. LisaException: The Python version 3.6.15 is lower than the required version 3.9. Please update Python to a versi |
| verify_openssl_version (lisa_0_64) | ✅ PASSED | 2.443 | |
| verify_azure_64bit_os (lisa_0_65) | ✅ PASSED | 1.527 | |
| verify_omi_version (lisa_0_66) | ✅ PASSED | 2.998 | |
| verify_no_swap_on_osdisk (lisa_0_67) | ✅ PASSED | 2.143 | |
| verify_essential_kernel_modules (lisa_0_68) | ❌ FAILED | 2.528 | failed. AssertionError: [Not enabled essential kernel modules for Hyper-V / Azure platform found.] Expected <['wdt']> to |
| verify_kvp (lisa_0_0) | ✅ PASSED | 12.970 | |
| verify_dhcp_client_timeout (lisa_0_39) | ✅ PASSED | 2.736 | |
| verify_dns_name_resolution (lisa_0_69) | ✅ PASSED | 2.561 | |
| verify_floppy_module_is_blacklisted (lisa_0_21) | ✅ PASSED | 2.093 | |
| verify_initrd_modules (lisa_0_34) | ✅ PASSED | 3.117 |
🤖 AI Test SelectionNo test cases were selected for this PR. |
Comment on lines
+113
to
+118
| service = self.node.tools[Service] | ||
| service.restart_service(self._smb_service) | ||
| service.restart_service(self._nmb_service) | ||
| # stop firewall to allow SMB traffic | ||
| self.node.tools[Firewall].stop() | ||
| self.node.mark_dirty() |
🤖 AI Test SelectionNo test cases were selected for this PR. |
❌ AI Test Selection — FAILED74 test case(s) selected (view run) Marketplace image: suse sles-15-sp6 gen2 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New testcase 'verify_smb_linux'
A test to verify CIFS module and SMB share functionality between two Linux VMs. SMB server and client tools are added which are useful in validating samba file share with Linux OS and CIFS module in kernel.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
verify_smb_linux
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results