perf_nvme : Remove requirement to have 8 NVMe#4500
Open
SRIKKANTH wants to merge 1 commit into
Open
Conversation
SRIKKANTH
requested review from
LiliDeng,
johnsongeorge-w and
lubaihua33
as code owners
NvmeSettings(disk_count=8) requirement is restricting the perf_nvme test from running VMs with lesser NVMe disks. For example ARM64 VM (like plds_v6) have max of 6 NVMes.
SRIKKANTH
force-pushed
the
smyakam/perf_nvme/max_disk/2026_05_28
branch
from
f0e6d41 to
b4ad8b6
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Removes the hardcoded NvmeSettings(disk_count=8) requirement from the perf_nvme test, replacing it with the generic Nvme feature requirement. This allows the test to run on VMs with fewer than 8 NVMe disks (e.g., ARM64 plds_v6 VMs with 6 NVMes), matching the existing pattern used by perf_nvme_io_uring. The runtime path already handles any disk count >= 1, and metric names dynamically include the actual disk count.
Changes:
- Drop
NvmeSettingsimport in favor of justNvme. - Replace
supported_features=[NvmeSettings(disk_count=8)]withsupported_features=[Nvme]forperf_nvme.
✅ AI Test Selection — PASSED2 test case(s) selected (view run) Marketplace image: canonical 0001-com-ubuntu-server-jammy 22_04-lts-gen2 latest
Test case details
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NvmeSettings(disk_count=8) requirement is restricting the perf_nvme test from running VMs with lesser NVMe disks. For example, ARM64 VM (like plds_v6) have max of 6 NVMes.
Description
Related Issue
Type of Change
Checklist
Test Validation
Key Test Cases:
perf_nvme
Impacted LISA Features:
Tested Azure Marketplace Images:
Test Results