fix: avoid rebinding attr backing fields on connect#7625
Merged
Conversation
Collaborator
Author
|
Marking this ready for review just to run pipelines against it. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
f9c6240 to
6623928
Compare
Collaborator
Author
|
For some strange reason the required Github Actions are not running against this PR, individual runs have been triggered. Edit: unnecessary they are now passing |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
chrisdholt
approved these changes
Jun 26, 2026
radium-v
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
📖 Description
Fixes
ElementControllerobservable capture/rebind behavior so FAST internal backing fields, including object-valued@attrfields that have already passed throughValueConverter.fromView(), are not normalized back to public property assignments duringconnect().This restores the expected behavior for converters such as JSON parsers while preserving pre-upgrade public observable capture and opt-in observer-map behavior.
🎫 Issues
👩💻 Reviewer Notes
Please focus review on the interaction between
captureBoundObservables(),bindObservables(),AttributeDefinition.setValue(), and opt-inobserverMap()proxying for public own properties.📑 Test Plan
npm cinpm run build:tsc -w @microsoft/fast-elementnpm run build:rollup -w @microsoft/fast-elementnpm run build:sizes -w @microsoft/fast-elementnpm run doc -w @microsoft/fast-elementnpm run doc:exports -w @microsoft/fast-elementnpm run prebuild -w sites/websitenpx biome check packages/fast-element/src/components/element-controller.ts packages/fast-element/src/components/element-controller.pw.spec.ts packages/fast-element/src/declarative/extension-subpaths.pw.spec.tsnpx playwright test --project=chromium src/components/element-controller.pw.spec.ts src/declarative/extension-subpaths.pw.spec.tsnpm run checkchangenpm run test:validation✅ Checklist
General
$ npm run change