Make netebpfext unit test resilient to fault injection. - #5547
Open
Shankar Seal (shankarseal) wants to merge 2 commits into
Open
Make netebpfext unit test resilient to fault injection.#5547Shankar Seal (shankarseal) wants to merge 2 commits into
Shankar Seal (shankarseal) wants to merge 2 commits into
Conversation
Shankar Seal (shankarseal)
requested review from
Alan Jowett (Alan-Jowett),
Andrew Beltrano (abeltrano),
Dave Thaler (dthaler),
Laksh (lakshk98),
Matthew Ige (matthewige),
Maksim S. (maxsud),
D. Michael Agun (mikeagun),
Michael Friesen (mtfriesen) and
poornagmsft
as code owners
August 31, 2026 22:02
Shankar Seal (shankarseal)
requested a review
from Anurag Saxena (saxena-anurag)
as a code owner
August 31, 2026 22:02
This comment was marked as resolved.
This comment was marked as resolved.
Shankar Seal (shankarseal)
marked this pull request as draft
August 31, 2026 22:12
Shankar Seal (shankarseal)
force-pushed
the
shankarseal-fix-netebpfext-fault-injection
branch
from
September 1, 2026 01:29
0be3f74 to
a8e58db
Compare
This comment was marked as resolved.
This comment was marked as resolved.
1 similar comment
This comment was marked as resolved.
This comment was marked as resolved.
added 2 commits
September 1, 2026 18:13
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea587460-e416-414f-9687-d52ae0a34d8f
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: ea587460-e416-414f-9687-d52ae0a34d8f
Shankar Seal (shankarseal)
force-pushed
the
shankarseal-fix-netebpfext-fault-injection
branch
from
September 2, 2026 01:13
dba2b3f to
60bebfe
Compare
This comment was marked as resolved.
This comment was marked as resolved.
Shankar Seal (shankarseal)
marked this pull request as ready for review
September 2, 2026 01:20
Laksh (lakshk98)
approved these changes
Sep 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Co-authored-by: Copilot App 223556219+Copilot@users.noreply.github.com
Description
Fixes #5460 .
Issues
FwpmFilterAdd0()in usersim.dll to fail during the netebpfext test case initialization, prior to NMR hook provider could bind, leaving the corresponding provider unavailable. Subsequent tests assumed initialization had succeeded, accessed the missing provider data, and crashed on a null pointer.fault.logfile was not getting uploadedChanges
The PR includes the following changes.
netebpfexttest helper initializes and tears down.NativeOnlyDebugconfiguration tonetebpfext_unit.vcxproj.Testing
Do any existing tests cover this change? Are new tests needed?
If new tests were added:
Documentation
Is there any documentation impact for this change?
Installation
Is there any installer impact for this change?