Skip to content

ci: remove unnecessary conda env and Azure auth from Style job #2544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
BrendanWalsh wants to merge 2 commits into
base: master
Choose a base branch
from
+5 −7
Open

ci: remove unnecessary conda env and Azure auth from Style job #2544

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e79867
ci: remove unnecessary conda env and Azure auth from Style job
BrendanWalsh Apr 4, 2026
694f769
ci: pin Python version for style check
BrendanWalsh Apr 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 5 additions & 7 deletions pipeline.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,17 +101,15 @@ jobs:
pool:
vmImage: $(UBUNTU_VERSION)
steps:
- task: AzureCLI@2
- bash: sbt scalastyle test:scalastyle
displayName: 'Scala Style Check'
- task: UsePythonVersion@0
displayName: 'Use Python 3'
inputs:
azureSubscription: 'SynapseML Build'
scriptLocation: inlineScript
scriptType: bash
inlineScript: 'sbt scalastyle test:scalastyle'
- template: templates/conda.yml
versionSpec: '3.10'
- bash: |
set -e
source activate synapseml
pip install -q "black[jupyter]==22.3.0"
black --diff --color . && black --check -q .
Comment on lines 110 to 113
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Style job now installs Black via pip, but unlike other jobs it no longer provisions a known Python runtime (e.g., via UsePythonVersion in templates/update_cli.yml) and also removed the conda environment that previously guaranteed a writable Python env. This can make pip install and/or the black executable resolution fail depending on the hosted agent image.

Consider adding an explicit Python setup step (or creating a venv) before installing/running Black, and optionally add the same retry/timeout pattern used elsewhere in the pipeline for pip installs to reduce transient CI failures.

See below for a potential fix:

    - task: UsePythonVersion@0
      displayName: 'Use Python 3'
      inputs:
        versionSpec: '3.10'
    - bash: |
        set -e
        python -m pip install --upgrade pip
        for i in 1 2 3; do
          python -m pip install -q "black[jupyter]==22.3.0" && break
          if [ "$i" -eq 3 ]; then
            exit 1
          fi
          sleep 10
        done
        python -m black --diff --color . && python -m black --check -q .

Copilot uses AI. Check for mistakes.
displayName: 'Python Style Check'
- ${{ if eq(parameters.publishArtifacts, true) }}:
Expand Down
Loading