Skip to content

fix(tree): prevent revert of commits that were rolled back#27520

Open
yann-achard-MS wants to merge 3 commits into
microsoft:mainfrom
yann-achard-MS:prevent-revert-of-rolledback-commits
Open

fix(tree): prevent revert of commits that were rolled back#27520
yann-achard-MS wants to merge 3 commits into
microsoft:mainfrom
yann-achard-MS:prevent-revert-of-rolledback-commits

Conversation

@yann-achard-MS

Copy link
Copy Markdown
Contributor

Description

A commit can be rolled back through SharedTreeCore.rollback. Once that is done, the revertible for that commits become invalid. Before this PR, we allowed applications to attempt a revert, which could either crash or perform undesirable edits. This PR ensures that the relevant revertible is disposed.

Breaking Changes

None

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (49 lines, 3 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@yann-achard-MS yann-achard-MS marked this pull request as ready for review June 10, 2026 17:00
@yann-achard-MS yann-achard-MS requested a review from a team as a code owner June 10, 2026 17:00
Copilot AI review requested due to automatic review settings June 10, 2026 17:00

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants