fix(tree): prevent revert of commits that were rolled back#27520
Open
yann-achard-MS wants to merge 3 commits into
Open
fix(tree): prevent revert of commits that were rolled back#27520yann-achard-MS wants to merge 3 commits into
yann-achard-MS wants to merge 3 commits into
Conversation
Contributor
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (49 lines, 3 files), I've queued these reviewers:
How this works
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A commit can be rolled back through
SharedTreeCore.rollback. Once that is done, the revertible for that commits become invalid. Before this PR, we allowed applications to attempt a revert, which could either crash or perform undesirable edits. This PR ensures that the relevant revertible is disposed.Breaking Changes
None