Skip to content

Marioja/breaking change setup#27518

Draft
MarioJGMsoft wants to merge 9 commits into
microsoft:mainfrom
MarioJGMsoft:marioja/breakingChangeSetup
Draft

Marioja/breaking change setup#27518
MarioJGMsoft wants to merge 9 commits into
microsoft:mainfrom
MarioJGMsoft:marioja/breakingChangeSetup

Conversation

@MarioJGMsoft

@MarioJGMsoft MarioJGMsoft commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Description

This branch is a test branch that merges both PR#27182 and P#27476. They are both related since they both do work for the telemetry API of Fluid Framework

Reviewer Guidance

The review process is outlined on this wiki page.

kian-thompson and others added 7 commits April 27, 2026 16:13
…FluidRunnerLogger

Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…lemetryLoggerExt`

- Remove deprecated methods from external `ITelemetryLoggerExt` and replace with branded type.
- Retag related telemetry types as `@internal` and remove `@deprecated` tags where applicable.
# Conflicts:
#	packages/tools/fluid-runner/src/exportFile.ts
#	packages/tools/fluid-runner/src/logger/loggerUtils.ts
# Conflicts:
#	packages/utils/telemetry-utils/src/test/utils.spec.ts
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Hi! Thank you for opening this PR. Want me to review it?

Based on the diff (404 lines, 25 files), I've queued these reviewers:

  • Correctness — logic errors, race conditions, lifecycle issues
  • Security — vulnerabilities, secret exposure, injection
  • API Compatibility — breaking changes, release tags, type design
  • Performance — algorithmic regressions, memory leaks
  • Testing — coverage gaps, hollow tests

How this works

  • Adjust the reviewer set by ticking/unticking boxes above. Reviewer toggles alone don't trigger anything.

  • Tick Start review below to dispatch the review fleet.

  • After review finishes, tick Start review again to request another run — it auto-resets after each dispatch.

  • This comment updates as new commits land; your reviewer selections are preserved.

  • Start review

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🔗 No broken links found! ✅

Your attention to detail is admirable.

linkcheck output


> fluid-framework-docs-site@0.0.0 ci:check-links /home/runner/work/FluidFramework/FluidFramework/docs
> start-server-and-test "npm run serve -- --no-open" 3000 check-links

1: starting server using command "npm run serve -- --no-open"
and when url "[ 'http://127.0.0.1:3000' ]" is responding with HTTP status code 200
running tests using command "npm run check-links"


> fluid-framework-docs-site@0.0.0 serve
> docusaurus serve --no-open

[SUCCESS] Serving "build" directory at: http://localhost:3000/

> fluid-framework-docs-site@0.0.0 check-links
> linkcheck http://localhost:3000 --skip-file skipped-urls.txt

Crawling...

Stats:
  290922 links
    1934 destination URLs
    2184 URLs ignored
       0 warnings
       0 errors


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants