Simplify pipelines #27505
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,7 +1,22 @@ | ||
| # Copyright (c) Microsoft Corporation and contributors. All rights reserved. | ||
| # Licensed under the MIT License. | ||
|
|
||
| # build-npm-client-package template | ||
| # | ||
| # This template exists as a specialized variant of build-npm-package for the | ||
| # client release group pipeline (Build - client packages). It was split from | ||
| # the generic template because the client pipeline has additional behavior and | ||
| # artifact contracts that other npm package pipelines do not require. | ||
| # | ||
| # Key differences from build-npm-package: | ||
| # - Captures and publishes build output archive (build_output_archive) for | ||
| # downstream test pipelines. | ||
| # - Runs tests in dedicated jobs (coverage + per-task fan-out) rather than only | ||
| # inline in the main build job. | ||
| # - Builds and publishes the devtools browser extension artifact. | ||
| # - Includes client-specific telemetry and artifact shaping used by internal | ||
| # CI and follow-on workflows. | ||
| # | ||
|
|
||
| parameters: | ||
| - name: buildDirectory | ||
|
|
@@ -37,10 +52,6 @@ parameters: | |
| type: boolean | ||
| default: false | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Might be preferable to leave the bundle size stuff for now, Tommy and I are making changes in this area and some of this is probably going to change anyway. Since the bundle size artifacts live in the client-side of the world it may make more sense for them to be produced over here...? |
||
| - name: taskPack | ||
| type: boolean | ||
| default: true | ||
|
|
@@ -74,20 +85,12 @@ parameters: | |
| type: string | ||
| default: repo | ||
|
|
||
| # Parameter for modifying the 'types' field in the package.json. | ||
| # If the value 'none' is provided, the 'types' field in package.json will remain unchanged. | ||
| - name: packageTypesOverride | ||
| type: string | ||
| default: none | ||
|
|
||
| # The semver range constraint to use for interdependencies; that is, dependencies on other packages within the release | ||
| # group | ||
| - name: interdependencyRange | ||
|
|
@@ -331,21 +334,16 @@ extends: | |
|
|
||
| - template: /tools/pipelines/templates/include-install.yml@self | ||
| parameters: | ||
| buildDirectory: '${{ parameters.buildDirectory }}' | ||
|
|
||
| - template: /tools/pipelines/templates/include-set-package-version.yml@self | ||
| parameters: | ||
| buildDirectory: '${{ parameters.buildDirectory }}' | ||
| buildNumberInPatch: ${{ parameters.buildNumberInPatch }} | ||
| buildToolsVersionToInstall: '${{ parameters.buildToolsVersionToInstall }}' | ||
| tagName: '${{ parameters.tagName }}' | ||
| interdependencyRange: '${{ parameters.interdependencyRange }}' | ||
| packageTypesOverride: '${{ parameters.packageTypesOverride }}' | ||
|
|
||
| # Build and Lint | ||
| - template: /tools/pipelines/templates/include-build-lint.yml@self | ||
|
|
@@ -382,7 +380,7 @@ extends: | |
| - task: Bash@3 | ||
| displayName: npm pack | ||
| env: | ||
| PACKAGE_MANAGER: 'pnpm' | ||
| RELEASE_GROUP: '${{ parameters.tagName }}' | ||
| STAGING_PATH: $(Build.ArtifactStagingDirectory) | ||
| inputs: | ||
|
|
@@ -449,29 +447,28 @@ extends: | |
| # At this point we want to publish the artifact with the _api-extractor-temp folder, | ||
| # but as part of 1ES migration that's now part of templateContext.outputs below. | ||
|
|
||
| # Reset the pnpm-lock.yaml file since it's been modified by the versioning. But for dependency caching we want | ||
| # the cache key (which is based on the contents of the lockfile) to be the unmodified file. So we reset the | ||
| # lockfile as the last step so that when the dependency cache is uploaded, the cache key matches what it was | ||
| # at the beginning of the CI job. | ||
| - task: Bash@3 | ||
| displayName: Reset lockfile | ||
| inputs: | ||
| targetType: inline | ||
| workingDirectory: '$(Pipeline.Workspace)/${{ parameters.buildDirectory }}' | ||
| script: | | ||
| set -eu -o pipefail | ||
| git checkout HEAD -- pnpm-lock.yaml | ||
|
|
||
| # Prune the pnpm store before it's cached. This removes any deps that are not used by the current build. | ||
| - task: Bash@3 | ||
| displayName: Prune pnpm store | ||
| inputs: | ||
| targetType: inline | ||
| workingDirectory: '$(Pipeline.Workspace)/${{ parameters.buildDirectory }}' | ||
| script: | | ||
| set -eu -o pipefail | ||
| pnpm store prune | ||
|
|
||
| - task: Bash@3 | ||
| displayName: Check for extraneous modified files | ||
|
|
@@ -600,9 +597,7 @@ extends: | |
|
|
||
| - template: /tools/pipelines/templates/include-install.yml@self | ||
| parameters: | ||
| buildDirectory: '${{ parameters.buildDirectory }}' | ||
|
|
||
| # We need it in order to run flub where the code coverage comparison logic calls for it | ||
| - template: /tools/pipelines/templates/include-install-build-tools.yml@self | ||
|
|
@@ -764,9 +759,7 @@ extends: | |
|
|
||
| - template: /tools/pipelines/templates/include-install.yml@self | ||
| parameters: | ||
| buildDirectory: '${{ parameters.buildDirectory }}' | ||
|
|
||
| - task: DownloadPipelineArtifact@2 | ||
| inputs: | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was this just duplicate?