tree: Fix bug with node existence revert constraint#27492
Conversation
|
Hi! Thank you for opening this PR. Want me to review it? Based on the diff (94 lines, 3 files), I've queued these reviewers:
How this works
|
| const handler = getChangeHandler(this.fieldKinds, field.fieldKind); | ||
| for (const [nodeId, inputIndex, outputIndex] of handler.getNestedChanges(field.change)) { | ||
| for (const [nodeId, inputIndex, _outputIndex] of handler.getNestedChanges( | ||
| field.change, |
There was a problem hiding this comment.
Looks like this was the only code path where the output index was used. You could remove it from the getNestedChanges contract (and all computations of it) as part of this PR, or we could do that in a separate PR, I don't mind.
There was a problem hiding this comment.
I think that can be a separate PR.
Co-authored-by: yann-achard-MS <97201204+yann-achard-MS@users.noreply.github.com>
Description
Fixed a bug where if a node existence revert constraint was placed on a node moved in the same transaction, the revert constraint would be violated when rebasing over any change. This PR changes the implementation of the node existence revert constraint to detect violations during invert instead of during rebasing.