Emergency downgrade some deps to unbreak pacote, publishing - #1087
Merged
Conversation
Member
Author
|
This worked. The thing I'm seeing is that at some point, transitive deps of pacote started filtering out deprecated versions; note the version numbers listed above. I think the problem was almost assuredly npm/npm-pick-manifest#33 given we went from npm-pick-manifest@9.0.0 to npm-pick-manifest@9.1.0. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before #1082, pacote returned:
But now it returns:
Note that there's no
deprecatedfield.There's something wrong in the transitive deps of pacote. I've reverted the lockfile, then fixed things until we compiled again, and retested that we get the right result again.