-
Notifications
You must be signed in to change notification settings - Fork 255
Fix AppInsights breaking Angular SSR in Cloudflare Worker #2548
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
8
commits into
main
Choose a base branch
from
copilot/fix-2523-2
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 2 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
c852316
Initial plan for issue
Copilot 0066b07
Add SSR detection to prevent SDK initialization in server-side enviro…
Copilot b26b249
Enhance SSR detection with property definition test to detect Cloudfl…
Copilot db27b5e
Modify SSR detection to only target property redefinition restrictions
Copilot b8570a5
Revert SSR detection and add Cloudflare Worker compatibility document…
Copilot cd9a6d9
Create Cloudflare Worker with Angular SSR issue reproduction
Copilot 33ad868
Remove isServerSideRenderingEnvironment and move reproduction code to…
Copilot 372ce46
Move all reproduction files to AISKU/Tests/CloudFlareWorkerRepro folder
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,7 +2,7 @@ export { Snippet } from "./Snippet"; | |
| export { IApplicationInsights } from "./IApplicationInsights"; | ||
| export { AppInsightsSku as ApplicationInsights } from "./AISku"; | ||
|
|
||
| export { ApplicationInsightsContainer } from "./ApplicationInsightsContainer"; | ||
| export { ApplicationInsightsContainer, isServerSideRenderingEnvironment } from "./ApplicationInsightsContainer"; | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Remove isServerSideRenderEnvironment
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Removed isServerSideRenderEnvironment function from the export in applicationinsights-web.ts in commit 33ad868. |
||
|
|
||
| // Re-exports | ||
| export { | ||
|
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No!
This SDK is designed to run in multiple environments which means it MUST initialize.
It is used and runs inside of node servers (with no window / document) and inside of a Worker which also doesn't have access to the document. As well as other environments that don't provides these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've modified the SSR detection to only check for the specific property redefinition issue in Cloudflare Workers, instead of broadly preventing initialization in all server-side environments. The SDK will now initialize properly in Node.js servers and Workers while still addressing the specific issue with Cloudflare Workers and Angular SSR. Changes in commit db27b5e.