Fix Safari SecurityError when Block All Cookies is enabled

shared/AppInsightsCommon/src/Interfaces/Context/IApplication.ts

@@ -11,4 +11,4 @@ export interface IApplication {
      * The application build version.
      */
     build: string;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/IDevice.ts

@@ -25,4 +25,4 @@ export interface IDevice {
      * The IP address.
      */
     ip: string;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/IInternal.ts

@@ -26,4 +26,4 @@ export interface IInternal {
      * Identifies the source of the sdk script
      */
     sdkSrc: string;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/ILocation.ts

@@ -6,4 +6,4 @@ export interface ILocation {
      * Client IP address for reverse lookup
      */
     ip: string;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/ISample.ts

@@ -10,4 +10,4 @@ export interface ISample {
     sampleRate: number;
 
     isSampledIn(envelope: ITelemetryItem): boolean;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/ISession.ts

@@ -19,4 +19,4 @@ export interface ISession {
      * Per the spec the ID will be regenerated if more than renewalSpan milliseconds elapse from this time with no activity.
      */
     renewalDate?: number;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/ITelemetryTrace.ts

@@ -30,4 +30,4 @@ export interface ITelemetryTrace {
 }
 
 export interface ITraceState {
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/IUser.ts

@@ -47,4 +47,4 @@ export interface IUserContext extends IUser {
     setAuthenticatedUserContext(authenticatedUserId: string, accountId?: string, storeInCookie?: boolean): void;
     clearAuthenticatedUserContext(): void;
     update (userId?: string): void;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Context/IWeb.ts

@@ -36,4 +36,4 @@ export interface IWeb {
      * Current domain. Leverages Window.location.hostname. populated to properties bag
      */
     domain: string;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Contracts/ContextTagKeys.ts

@@ -296,4 +296,4 @@ export class ContextTagKeys extends createClassFromInterface<IContextTagKeys>({
     constructor() {
         super();
     }
-}
+}

shared/AppInsightsCommon/src/Interfaces/Contracts/DataPointType.ts

@@ -7,4 +7,4 @@
 export const enum DataPointType {
     Measurement = 0,
     Aggregation = 1
-}
+}

shared/AppInsightsCommon/src/Interfaces/Contracts/IData.ts

@@ -16,4 +16,4 @@ export interface IData<TDomain> extends IBase {
      * Container for data item (B section).
      */
     baseData: TDomain;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Contracts/SeverityLevel.ts

@@ -25,4 +25,4 @@ export const SeverityLevel = createEnumStyle<typeof eSeverityLevel>({
     Critical: eSeverityLevel.Critical
 });
 
-export type SeverityLevel = number | eSeverityLevel;
+export type SeverityLevel = number | eSeverityLevel;

shared/AppInsightsCommon/src/Interfaces/ICorrelationConfig.ts

@@ -97,4 +97,4 @@ export interface ICorrelationConfig {
      * should not be excluded.
      */
     addIntEndpoints?: boolean;
-}
+}

shared/AppInsightsCommon/src/Interfaces/IPageViewPerformanceTelemetry.ts

@@ -58,4 +58,4 @@ export interface IPageViewPerformanceTelemetryInternal extends IPageViewPerforma
      * Duration in miliseconds
      */
     durationMs?: number;
-}
+}

shared/AppInsightsCommon/src/Interfaces/IPropertiesPlugin.ts

@@ -5,4 +5,4 @@ import { ITelemetryContext } from "./ITelemetryContext";
 
 export interface IPropertiesPlugin {
     readonly context: ITelemetryContext;
-}
+}

shared/AppInsightsCommon/src/Interfaces/IStorageBuffer.ts

@@ -16,4 +16,4 @@ export interface IStorageBuffer {
      * Sets the stored value for a given key
      */
     setItem(logger: IDiagnosticLogger, name: string, data: string): boolean;
-}
+}

shared/AppInsightsCommon/src/Interfaces/PartAExtensions.ts

@@ -11,4 +11,4 @@ export const Extensions = {
     SDKExt: "sdk"
 };
 
-export let CtxTagKeys = new ContextTagKeys();
+export let CtxTagKeys = new ContextTagKeys();

shared/AppInsightsCommon/src/Interfaces/Telemetry/IEnvelope.ts

@@ -44,4 +44,4 @@ export interface IEnvelope extends ISerializable {
      * Telemetry data item.
      */
     data: any;
-}
+}

shared/AppInsightsCommon/src/Interfaces/Telemetry/ISerializable.ts

@@ -8,4 +8,4 @@ export interface ISerializable {
      * for each field defines whether the field is required or not.
      */
     aiDataContract: any;
-}
+}

shared/AppInsightsCommon/src/RequestResponseHeaders.ts

@@ -93,4 +93,3 @@ export const RequestHeaders = createValueMap<typeof eRequestHeaders, IRequestHea
     sdkContextHeaderAppIdRequest: [ eRequestHeaders.sdkContextHeaderAppIdRequest, "appId"],
     requestContextHeaderLowerCase: [ eRequestHeaders.requestContextHeaderLowerCase, "request-context"]
 });
-

shared/AppInsightsCommon/src/StorageHelperFuncs.ts

@@ -23,6 +23,53 @@ function _getLocalStorageObject(): Storage {
     return null;
 }
 
+/**
+ * Safely checks if storage object (localStorage or sessionStorage) is available and accessible
+ * This helps prevent SecurityError in some browsers (e.g., Safari) when cookies are blocked
+ * @param storageType - Type of storage
+ * @returns {boolean} Returns whether storage object is safely accessible
+ */
+function _canSafelyAccessStorage(storageType: StorageType): boolean {
+    const storageTypeName = storageType === StorageType.LocalStorage ? "localStorage" : "sessionStorage";
+
+    try {
+        // First, check if window exists
+        if (isNullOrUndefined(getGlobal())) {
+            return false;
+        }
+
+        // Try to indirectly check if the property exists and is accessible
+        // This avoids direct property access that might throw in Safari with "Block All Cookies" enabled
+        const gbl: any = getGlobal();
+
+        // Some browsers throw when accessing the property descriptors with getOwnPropertyDescriptor
+        // Others throw when directly accessing the storage objects
+        // This approach tries both methods safely
+        try {
+            // Method 1: Try using property descriptor - safer in Safari with cookies blocked
+            const descriptor = Object.getOwnPropertyDescriptor(gbl, storageTypeName);
+            if (!descriptor || !descriptor.get) {
+                return false;
+            }
+        } catch (e) {
+            // If the above fails, attempt a direct access inside a try-catch
+            try {
+                const storage = gbl[storageTypeName];
+                if (!storage) {
+                    return false;
+                }
+            } catch (e) {
+                // If both approaches fail, storage cannot be safely accessed
+                return false;
+            }
+        }
+
+        return true;
+    } catch (e) {
+        return false;
+    }
+}
+
 /**
  * Tests storage object (localStorage or sessionStorage) to verify that it is usable
  * More details here: https://mathiasbynens.be/notes/localstorage-pattern
@@ -31,20 +78,30 @@ function _getLocalStorageObject(): Storage {
  */
 function _getVerifiedStorageObject(storageType: StorageType): Storage {
     try {
-        if (isNullOrUndefined(getGlobal())) {
+        // First check if we can safely access the storage object
+        if (!_canSafelyAccessStorage(storageType)) {
             return null;
         }
-        let uid = (new Date).toString();
-        let storage: Storage = getGlobalInst(storageType === StorageType.LocalStorage ? "localStorage" : "sessionStorage");
-        let name:string = _storagePrefix + uid;
-        storage.setItem(name, uid);
-        let fail = storage.getItem(name) !== uid;
-        storage.removeItem(name);
-        if (!fail) {
-            return storage;
+
+        const storageTypeName = storageType === StorageType.LocalStorage ? "localStorage" : "sessionStorage";
+
+        // Now we can safely try to use the storage
+        try {
+            let uid = (new Date).toString();
+            let storage: Storage = getGlobalInst(storageTypeName);
+            let name:string = _storagePrefix + uid;
+            storage.setItem(name, uid);
+            let fail = storage.getItem(name) !== uid;
+            storage.removeItem(name);
+            if (!fail) {
+                return storage;
+            }
+        } catch (exception) {
+            // Storage exists but can't be used (quota exceeded, etc.)
+            return null;
         }
     } catch (exception) {
-        // eslint-disable-next-line no-empty
+        // Catch any unexpected errors
     }
 
     return null;