-
Notifications
You must be signed in to change notification settings - Fork 255
Fix Safari SecurityError when Block All Cookies is enabled #2539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Copilot
wants to merge
25
commits into
main
Choose a base branch
from
copilot/fix-2494
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 5 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
e1a71fb
Initial plan for issue
Copilot d1ffffc
Fix Safari SecurityError when Block All Cookies is set
Copilot c13a592
Fix PR comments on StorageHelperFuncs.ts
Copilot 16f3b92
Remove newline changes from interface files per PR feedback
Copilot a488d75
Refactor storage helper functions to use single return statements per…
Copilot fd68d94
Remove generated JS files from PR per feedback
Copilot 831c9b4
Remove RequestResponseHeaders.ts from PR per reviewer feedback
Copilot d472d65
Pass resolved string to _canSafelyAccessStorage per PR feedback
Copilot d2cd04d
Merge _canSafelyAccessStorage function into _getVerifiedStorageObject
Copilot 93c0f44
Simplify storage access code with default-false approach
Copilot d4677e0
Merge branch 'main' into copilot/fix-2494
MSNev cdf088a
Remove unnecessary nested try-catch for direct storage access
Copilot 22169a2
Merge branch 'main' into copilot/fix-2494
MSNev cee30cd
Add caching to storage verification to reduce test item creation
Copilot 9e5c985
Update storage caching to use createCachedValue instead of reset
Copilot d0ee829
Remove _canUseLocalStorage and _canUseSessionStorage flags, add stora…
Copilot 2274771
Don't reset cached storage on getItem and read operations
Copilot 59362d4
Simplify storage wrapper and remove redundant code
Copilot b9789af
Use existing helper functions in utlCanUseLocalStorage/SessionStorage
Copilot e775471
Refactor storage helper functions to reduce code duplication and fix …
Copilot d25a325
Merge branch 'main' into copilot/fix-2494
MSNev 7e32aa3
Address PR comments for StorageHelperFuncs.ts
Copilot ec81543
Refactor storage functions per PR feedback
Copilot 23f5e50
Refactor utlCanUseLocalStorage and utlCanUseSessionStorage to include…
Copilot 98c0e2c
Revert utility functions to original form while keeping _throwInterna…
Copilot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,42 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.ConnectionStringParser = void 0; | ||
| exports.parseConnectionString = parseConnectionString; | ||
| var applicationinsights_core_js_1 = require("@microsoft/applicationinsights-core-js"); | ||
| var Constants_1 = require("./Constants"); | ||
| var _FIELDS_SEPARATOR = ";"; | ||
| var _FIELD_KEY_VALUE_SEPARATOR = "="; | ||
| function parseConnectionString(connectionString) { | ||
| if (!connectionString) { | ||
| return {}; | ||
| } | ||
| var kvPairs = connectionString.split(_FIELDS_SEPARATOR); | ||
| var result = (0, applicationinsights_core_js_1.arrReduce)(kvPairs, function (fields, kv) { | ||
| var kvParts = kv.split(_FIELD_KEY_VALUE_SEPARATOR); | ||
| if (kvParts.length === 2) { // only save fields with valid formats | ||
| var key = kvParts[0].toLowerCase(); | ||
| var value = kvParts[1]; | ||
| fields[key] = value; | ||
| } | ||
| return fields; | ||
| }, {}); | ||
| if ((0, applicationinsights_core_js_1.objKeys)(result).length > 0) { | ||
| // this is a valid connection string, so parse the results | ||
| if (result.endpointsuffix) { | ||
| // apply the default endpoints | ||
| var locationPrefix = result.location ? result.location + "." : ""; | ||
| result.ingestionendpoint = result.ingestionendpoint || ("https://" + locationPrefix + "dc." + result.endpointsuffix); | ||
| } | ||
| // apply user override endpoint or the default endpoints | ||
| result.ingestionendpoint = result.ingestionendpoint || Constants_1.DEFAULT_BREEZE_ENDPOINT; | ||
| if ((0, applicationinsights_core_js_1.strEndsWith)(result.ingestionendpoint, "/")) { | ||
| result.ingestionendpoint = result.ingestionendpoint.slice(0, -1); | ||
| } | ||
| } | ||
| return result; | ||
| } | ||
| exports.ConnectionStringParser = { | ||
| parse: parseConnectionString | ||
| }; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.strIkey = exports.strNotSpecified = exports.DEFAULT_BREEZE_PATH = exports.DEFAULT_BREEZE_ENDPOINT = exports.HttpMethod = exports.ProcessLegacy = exports.SampleRate = exports.DisabledPropertyName = void 0; | ||
| /** | ||
| * This is an internal property used to cause internal (reporting) requests to be ignored from reporting | ||
| * additional telemetry, to handle polyfil implementations ALL urls used with a disabled request will | ||
| * also be ignored for future requests even when this property is not provided. | ||
| * Tagging as Ignore as this is an internal value and is not expected to be used outside of the SDK | ||
| * @ignore | ||
| */ | ||
| exports.DisabledPropertyName = "Microsoft_ApplicationInsights_BypassAjaxInstrumentation"; | ||
| exports.SampleRate = "sampleRate"; | ||
| exports.ProcessLegacy = "ProcessLegacy"; | ||
| exports.HttpMethod = "http.method"; | ||
| exports.DEFAULT_BREEZE_ENDPOINT = "https://dc.services.visualstudio.com"; | ||
| exports.DEFAULT_BREEZE_PATH = "/v2/track"; | ||
| exports.strNotSpecified = "not_specified"; | ||
| exports.strIkey = "iKey"; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.createDomEvent = createDomEvent; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| var applicationinsights_core_js_1 = require("@microsoft/applicationinsights-core-js"); | ||
| function createDomEvent(eventName) { | ||
| var event = null; | ||
| if ((0, applicationinsights_core_js_1.isFunction)(Event)) { // Use Event constructor when available | ||
| event = new Event(eventName); | ||
| } | ||
| else { // Event has no constructor in IE | ||
| var doc = (0, applicationinsights_core_js_1.getDocument)(); | ||
| if (doc && doc.createEvent) { | ||
| event = doc.createEvent("Event"); | ||
| event.initEvent(eventName, true, true); | ||
| } | ||
| } | ||
| return event; | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.EventPersistence = exports.DistributedTracingModes = exports.StorageType = void 0; | ||
| var applicationinsights_core_js_1 = require("@microsoft/applicationinsights-core-js"); | ||
| exports.StorageType = (0, applicationinsights_core_js_1.createEnumStyle)({ | ||
| LocalStorage: 0 /* eStorageType.LocalStorage */, | ||
| SessionStorage: 1 /* eStorageType.SessionStorage */ | ||
| }); | ||
| exports.DistributedTracingModes = (0, applicationinsights_core_js_1.createEnumStyle)({ | ||
| AI: 0 /* eDistributedTracingModes.AI */, | ||
| AI_AND_W3C: 1 /* eDistributedTracingModes.AI_AND_W3C */, | ||
| W3C: 2 /* eDistributedTracingModes.W3C */ | ||
| }); | ||
| /** | ||
| * The EventPersistence contains a set of values that specify the event's persistence. | ||
| */ | ||
| exports.EventPersistence = (0, applicationinsights_core_js_1.createEnumStyle)({ | ||
| /** | ||
| * Normal persistence. | ||
| */ | ||
| Normal: 1 /* EventPersistenceValue.Normal */, | ||
| /** | ||
| * Critical persistence. | ||
| */ | ||
| Critical: 2 /* EventPersistenceValue.Critical */ | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,50 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.stringToBoolOrDefault = stringToBoolOrDefault; | ||
| exports.msToTimeSpan = msToTimeSpan; | ||
| exports.getExtensionByName = getExtensionByName; | ||
| exports.isCrossOriginError = isCrossOriginError; | ||
| var applicationinsights_core_js_1 = require("@microsoft/applicationinsights-core-js"); | ||
| var ts_utils_1 = require("@nevware21/ts-utils"); | ||
| var strEmpty = ""; | ||
| function stringToBoolOrDefault(str, defaultValue) { | ||
| if (defaultValue === void 0) { defaultValue = false; } | ||
| if (str === undefined || str === null) { | ||
| return defaultValue; | ||
| } | ||
| return str.toString().toLowerCase() === "true"; | ||
| } | ||
| /** | ||
| * Convert ms to c# time span format | ||
| */ | ||
| function msToTimeSpan(totalms) { | ||
| if (isNaN(totalms) || totalms < 0) { | ||
| totalms = 0; | ||
| } | ||
| totalms = (0, ts_utils_1.mathRound)(totalms); | ||
| var ms = strEmpty + totalms % 1000; | ||
| var sec = strEmpty + (0, ts_utils_1.mathFloor)(totalms / 1000) % 60; | ||
| var min = strEmpty + (0, ts_utils_1.mathFloor)(totalms / (1000 * 60)) % 60; | ||
| var hour = strEmpty + (0, ts_utils_1.mathFloor)(totalms / (1000 * 60 * 60)) % 24; | ||
| var days = (0, ts_utils_1.mathFloor)(totalms / (1000 * 60 * 60 * 24)); | ||
| ms = ms.length === 1 ? "00" + ms : ms.length === 2 ? "0" + ms : ms; | ||
| sec = sec.length < 2 ? "0" + sec : sec; | ||
| min = min.length < 2 ? "0" + min : min; | ||
| hour = hour.length < 2 ? "0" + hour : hour; | ||
| return (days > 0 ? days + "." : strEmpty) + hour + ":" + min + ":" + sec + "." + ms; | ||
| } | ||
| function getExtensionByName(extensions, identifier) { | ||
| var extension = null; | ||
| (0, applicationinsights_core_js_1.arrForEach)(extensions, function (value) { | ||
| if (value.identifier === identifier) { | ||
| extension = value; | ||
| return -1; | ||
| } | ||
| }); | ||
| return extension; | ||
| } | ||
| function isCrossOriginError(message, url, lineNumber, columnNumber, error) { | ||
| return !error && (0, applicationinsights_core_js_1.isString)(message) && (message === "Script error." || message === "Script error"); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| "use strict"; | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
4 changes: 4 additions & 0 deletions
4
shared/AppInsightsCommon/src/Interfaces/Context/IApplication.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
4 changes: 4 additions & 0 deletions
4
shared/AppInsightsCommon/src/Interfaces/Context/IOperatingSystem.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
4 changes: 4 additions & 0 deletions
4
shared/AppInsightsCommon/src/Interfaces/Context/ISessionManager.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
4 changes: 4 additions & 0 deletions
4
shared/AppInsightsCommon/src/Interfaces/Context/ITelemetryTrace.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
47 changes: 47 additions & 0 deletions
47
shared/AppInsightsCommon/src/Interfaces/Contracts/AvailabilityData.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| "use strict"; | ||
| // // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // // Licensed under the MIT License. | ||
| // // THIS FILE WAS AUTOGENERATED | ||
| // import { Domain } from "./Domain"; | ||
| // "use strict"; | ||
| // /** | ||
| // * Instances of AvailabilityData represent the result of executing an availability test. | ||
| // */ | ||
| // export class AvailabilityData implements Domain { | ||
| // /** | ||
| // * Schema version | ||
| // */ | ||
| // public ver: number = 2; | ||
| // /** | ||
| // * Identifier of a test run. Use it to correlate steps of test run and telemetry generated by the service. | ||
| // */ | ||
| // public id: string; | ||
| // /** | ||
| // * Name of the test that these availability results represent. | ||
| // */ | ||
| // public name: string; | ||
| // /** | ||
| // * Duration in format: DD.HH:MM:SS.MMMMMM. Must be less than 1000 days. | ||
| // */ | ||
| // public duration: string; | ||
| // /** | ||
| // * Success flag. | ||
| // */ | ||
| // public success: boolean; | ||
| // /** | ||
| // * Name of the location where the test was run from. | ||
| // */ | ||
| // public runLocation: string; | ||
| // /** | ||
| // * Diagnostic message for the result. | ||
| // */ | ||
| // public message: string; | ||
| // /** | ||
| // * Collection of custom properties. | ||
| // */ | ||
| // public properties: any = {}; | ||
| // /** | ||
| // * Collection of custom measurements. | ||
| // */ | ||
| // public measurements: any = {}; | ||
| // } |
101 changes: 101 additions & 0 deletions
101
shared/AppInsightsCommon/src/Interfaces/Contracts/ContextTagKeys.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,101 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| var __extends = (this && this.__extends) || (function () { | ||
| var extendStatics = function (d, b) { | ||
| extendStatics = Object.setPrototypeOf || | ||
| ({ __proto__: [] } instanceof Array && function (d, b) { d.__proto__ = b; }) || | ||
| function (d, b) { for (var p in b) if (Object.prototype.hasOwnProperty.call(b, p)) d[p] = b[p]; }; | ||
| return extendStatics(d, b); | ||
| }; | ||
| return function (d, b) { | ||
| if (typeof b !== "function" && b !== null) | ||
| throw new TypeError("Class extends value " + String(b) + " is not a constructor or null"); | ||
| extendStatics(d, b); | ||
| function __() { this.constructor = d; } | ||
| d.prototype = b === null ? Object.create(b) : (__.prototype = b.prototype, new __()); | ||
| }; | ||
| })(); | ||
| Object.defineProperty(exports, "__esModule", { value: true }); | ||
| exports.ContextTagKeys = void 0; | ||
| var applicationinsights_core_js_1 = require("@microsoft/applicationinsights-core-js"); | ||
| function _aiNameFunc(baseName) { | ||
| var aiName = "ai." + baseName + "."; | ||
| return function (name) { | ||
| return aiName + name; | ||
| }; | ||
| } | ||
| var _aiApplication = _aiNameFunc("application"); | ||
| var _aiDevice = _aiNameFunc("device"); | ||
| var _aiLocation = _aiNameFunc("location"); | ||
| var _aiOperation = _aiNameFunc("operation"); | ||
| var _aiSession = _aiNameFunc("session"); | ||
| var _aiUser = _aiNameFunc("user"); | ||
| var _aiCloud = _aiNameFunc("cloud"); | ||
| var _aiInternal = _aiNameFunc("internal"); | ||
| var ContextTagKeys = /** @class */ (function (_super) { | ||
| __extends(ContextTagKeys, _super); | ||
| function ContextTagKeys() { | ||
| return _super.call(this) || this; | ||
| } | ||
| return ContextTagKeys; | ||
| }((0, applicationinsights_core_js_1.createClassFromInterface)({ | ||
| applicationVersion: _aiApplication("ver"), | ||
| applicationBuild: _aiApplication("build"), | ||
| applicationTypeId: _aiApplication("typeId"), | ||
| applicationId: _aiApplication("applicationId"), | ||
| applicationLayer: _aiApplication("layer"), | ||
| deviceId: _aiDevice("id"), | ||
| deviceIp: _aiDevice("ip"), | ||
| deviceLanguage: _aiDevice("language"), | ||
| deviceLocale: _aiDevice("locale"), | ||
| deviceModel: _aiDevice("model"), | ||
| deviceFriendlyName: _aiDevice("friendlyName"), | ||
| deviceNetwork: _aiDevice("network"), | ||
| deviceNetworkName: _aiDevice("networkName"), | ||
| deviceOEMName: _aiDevice("oemName"), | ||
| deviceOS: _aiDevice("os"), | ||
| deviceOSVersion: _aiDevice("osVersion"), | ||
| deviceRoleInstance: _aiDevice("roleInstance"), | ||
| deviceRoleName: _aiDevice("roleName"), | ||
| deviceScreenResolution: _aiDevice("screenResolution"), | ||
| deviceType: _aiDevice("type"), | ||
| deviceMachineName: _aiDevice("machineName"), | ||
| deviceVMName: _aiDevice("vmName"), | ||
| deviceBrowser: _aiDevice("browser"), | ||
| deviceBrowserVersion: _aiDevice("browserVersion"), | ||
| locationIp: _aiLocation("ip"), | ||
| locationCountry: _aiLocation("country"), | ||
| locationProvince: _aiLocation("province"), | ||
| locationCity: _aiLocation("city"), | ||
| operationId: _aiOperation("id"), | ||
| operationName: _aiOperation("name"), | ||
| operationParentId: _aiOperation("parentId"), | ||
| operationRootId: _aiOperation("rootId"), | ||
| operationSyntheticSource: _aiOperation("syntheticSource"), | ||
| operationCorrelationVector: _aiOperation("correlationVector"), | ||
| sessionId: _aiSession("id"), | ||
| sessionIsFirst: _aiSession("isFirst"), | ||
| sessionIsNew: _aiSession("isNew"), | ||
| userAccountAcquisitionDate: _aiUser("accountAcquisitionDate"), | ||
| userAccountId: _aiUser("accountId"), | ||
| userAgent: _aiUser("userAgent"), | ||
| userId: _aiUser("id"), | ||
| userStoreRegion: _aiUser("storeRegion"), | ||
| userAuthUserId: _aiUser("authUserId"), | ||
| userAnonymousUserAcquisitionDate: _aiUser("anonUserAcquisitionDate"), | ||
| userAuthenticatedUserAcquisitionDate: _aiUser("authUserAcquisitionDate"), | ||
| cloudName: _aiCloud("name"), | ||
| cloudRole: _aiCloud("role"), | ||
| cloudRoleVer: _aiCloud("roleVer"), | ||
| cloudRoleInstance: _aiCloud("roleInstance"), | ||
| cloudEnvironment: _aiCloud("environment"), | ||
| cloudLocation: _aiCloud("location"), | ||
| cloudDeploymentUnit: _aiCloud("deploymentUnit"), | ||
| internalNodeName: _aiInternal("nodeName"), | ||
| internalSdkVersion: _aiInternal("sdkVersion"), | ||
| internalAgentVersion: _aiInternal("agentVersion"), | ||
| internalSnippet: _aiInternal("snippet"), | ||
| internalSdkSrc: _aiInternal("sdkSrc") | ||
| }))); | ||
| exports.ContextTagKeys = ContextTagKeys; |
4 changes: 4 additions & 0 deletions
4
shared/AppInsightsCommon/src/Interfaces/Contracts/DataPointType.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
4 changes: 4 additions & 0 deletions
4
shared/AppInsightsCommon/src/Interfaces/Contracts/DependencyKind.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
4 changes: 4 additions & 0 deletions
4
shared/AppInsightsCommon/src/Interfaces/Contracts/DependencySourceType.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,4 @@ | ||
| "use strict"; | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. | ||
| Object.defineProperty(exports, "__esModule", { value: true }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove all of these new "generated" *.js files, the project uses TypeScript and we don't check in the *.js files except for specific tools
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed all the generated JavaScript files from the PR in commit fd68d94. The project will now only include the TypeScript source files as intended.