Skip to content

Replace deprecated codecs.open by open #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FriedrichFroebel wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Replace deprecated codecs.open by open #223

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bfb9d71
Replace deprecated codecs.open by open
FriedrichFroebel Oct 15, 2025
87b5447
use keyword arguments
FriedrichFroebel Mar 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions mf2py/backcompat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,6 @@

"""

import codecs
import copy
import json
import os
Expand All @@ -47,7 +46,7 @@
for filename in os.listdir(_RULES_LOC):
file_path = os.path.join(_RULES_LOC, filename)
root = os.path.splitext(filename)[0]
with codecs.open(file_path, "r", "utf-8") as f:
with open(file_path, "r", "utf-8") as f:
Copy link
Copy Markdown

@ysamlan ysamlan Mar 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, Python 3 open() takes encoding as a keyword argument, not positional. The third positional
parameter is buffering (expects an int), so this:

open(file_path, "r", "utf-8")

raises TypeError: 'str' object cannot be interpreted as an integer at import time on Python 3.14. Should be:

open(file_path, encoding="utf-8") ('r' is the default for mode, so that's optional).

> help(open)
Help on built-in function open in module _io:
open(
    file,
    mode='r',
    buffering=-1,
    encoding=None,
    errors=None,
    newline=None,
    closefd=True,
    opener=None
)

Copy link
Copy Markdown
Author

@FriedrichFroebel FriedrichFroebel Mar 14, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I did not test the change back then. I have made all the optional parameters keywords.

rules = json.load(f)

_CLASSIC_MAP[root] = rules
Expand Down