Revert beta MakeCode and use temporary version of makecode-embed#888
Merged
Conversation
|
Preview build will be at |
| lang={getMakeCodeLang(languageId)} | ||
| loading="eager" | ||
| version={ | ||
| getEditorVersionOverride() ?? (isNativePlatform() ? "beta" : undefined) |
There was a problem hiding this comment.
Need to reinstate getEditorVersionOverride()
microbit-matt-hillsdon
approved these changes
May 8, 2026
microbit-matt-hillsdon
left a comment
microbit-matt-hillsdon
left a comment
There was a problem hiding this comment.
LGTM subject to @microbit-grace manual testing.
Author
|
Did some Android and iOS testing (saving/sharing hex, MakeCode playing around, hammering trying to recreate the MakeCode loading issue) and it all seemed like main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We switched to MakeCode beta for our app testing because we needed microsoft/pxt#11196 as iframe+tablet seems to make it much easier to reproduce microsoft/pxt-microbit#6081 to the point where we felt it was unusable.
The temporary branch of makecode-embed works around the problem differently by using the noproject flag (like skillsmap seems to).
As this will resolve itself in this summer's MakeCode release we're not going to merge that change in makecode-embed — if MakeCode is visible at init time there's a notable visual glitch where the empty editor is rendered. Fortunately this does not apply to CreateAI.
makecode-embed change for reference: microbit-foundation/makecode-embed#14