Refactor: Split _conversion.py into domain modules, improve naming in _helper.py#489
Open
Wolfvin wants to merge 1 commit into
Open
Refactor: Split _conversion.py into domain modules, improve naming in _helper.py#489Wolfvin wants to merge 1 commit into
Wolfvin wants to merge 1 commit into
Conversation
… functions, improve _signal.py docstrings - Split _conversion.py (444 lines) into _conversion package: - _conversion/_decibels.py: db(), linear() functions - _conversion/_snr.py: SNR conversion functions - _conversion/__init__.py: Re-exports all public names - Rename functions in _helper.py with backward-compatible aliases: - _argument_names() -> _extract_caller_argument_names() - verify_scalar() -> verify_and_validate_scalar() - verify_arraylike() -> verify_and_validate_arraylike() - convert_output() -> normalize_output_type() - convert_to_scalar() -> demote_numpy_scalar_to_native() - Improve _signal.py: - Module docstring: 'Signal generation and transformation functions...' - Updated Group tags from 'dsp-signal-manipulation' to specific groups - Updated internal references to use new canonical names
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #489 +/- ##
==========================================
+ Coverage 81.81% 82.20% +0.38%
==========================================
Files 63 65 +2
Lines 3960 4119 +159
==========================================
+ Hits 3240 3386 +146
- Misses 720 733 +13 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Structural Refactoring with Regression Testing Proof
All changes are backward-compatible.
What was refactored
_conversion.py (444 lines) split into _conversion/ package
_helper.py naming improvements
_signal.py docstring improvements
Regression Testing Proof (Regrets)
18 clusters tested, 4 chains validated, 0 false positives.
All 4 verifications passed: