Skip to content

Fix package single version handling #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SamiAlavi wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix package single version handling #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bc7e674
handle single-version packages correctly
SamiAlavi Aug 21, 2024
7b32297
refactor getPackageVersion
SamiAlavi Aug 21, 2024
ebbd76d
add comment for fix
SamiAlavi Aug 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 13 additions & 18 deletions main.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,26 +11,21 @@ const rimraf = require("rimraf");
const utils = require("./npm-utils");

const getPackageVersion = async (packageName, version) => {
let versions = [];
try {
versions = await utils.getVersionList(packageName);
} catch (e) {
throw new Error(e.message);
}
if (!version) {
version = versions[versions.length - 1];
}
let found = false;
for (const v of versions) {
if (v === version) {
found = true;
break;
}
}
if (found) {
return version;
const versionList = await utils.getVersionList(packageName);

// If there is only a single version, `npm show ${name} versions --json` returns a string.
// This ensures `versions` is always an array, even if there's only one version.
const versions = Array.isArray(versionList) ? versionList : [versionList];

// Default to the latest version if no specific version is provided
version = version || versions[versions.length - 1];

// Check if the desired version exists in the versions list
return versions.includes(version) ? version : undefined;
} catch (error) {
throw new Error(error.message);
}
return undefined;
};

const initializeTempDir = (packageName, indexName) => {
Expand Down