Skip to content

Add normalize_slices option to pf2 and vcsc dependency - #513

Merged
aarmey merged 2 commits into
mainfrom
add-normalize-slices-vcsc-dep
Aug 24, 2026
Merged

aarmey merged 2 commits into
mainfrom
add-normalize-slices-vcsc-dep

Conversation

@aarmey

@aarmey aarmey commented Aug 24, 2026

Copy link
Copy Markdown
Member

Summary

  • Add normalize_slices parameter to pf2() to normalize per-condition slices by Frobenius norm during factor updates, preventing conditions with large cell counts from dominating
  • Switch parafac2 dependency from pinned tag v1.4.0 to tracking the latest git revision
  • Add vcsc (anndata-VCSC) as a new dependency
  • Update lockfile with GPU deps (cupy-cuda12x replacing cupy, plus CUDA toolkit wheels)

Test plan

  • uv sync resolves cleanly
  • pf2() runs with normalize_slices=True and False

🤖 Generated with Claude Code

https://claude.ai/code/session_015GRmxFJ5UZ4worNmd5gKfc

aarmey and others added 2 commits August 23, 2026 21:14
Adds normalize_slices to pf2() so per-condition slices can be normalized
by Frobenius norm during factor updates, preventing large-cell-count
conditions from dominating. Also switches parafac2 to track the latest
git revision instead of a pinned tag, and adds the vcsc (anndata-VCSC)
dependency along with updated GPU (cupy-cuda12x) lockfile entries.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015GRmxFJ5UZ4worNmd5gKfc
…vcsc-dep

# Conflicts:
#	RISE/factorization.py
#	uv.lock
@aarmey
aarmey merged commit 72e92bc into main Aug 24, 2026
2 checks passed
@aarmey
aarmey deleted the add-normalize-slices-vcsc-dep branch August 24, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant