Repository navigation
Add normalize_slices option to pf2 and vcsc dependency - #513
Merged
Merged
Conversation
Adds normalize_slices to pf2() so per-condition slices can be normalized by Frobenius norm during factor updates, preventing large-cell-count conditions from dominating. Also switches parafac2 to track the latest git revision instead of a pinned tag, and adds the vcsc (anndata-VCSC) dependency along with updated GPU (cupy-cuda12x) lockfile entries. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015GRmxFJ5UZ4worNmd5gKfc
…vcsc-dep # Conflicts: # RISE/factorization.py # uv.lock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
normalize_slicesparameter topf2()to normalize per-condition slices by Frobenius norm during factor updates, preventing conditions with large cell counts from dominatingparafac2dependency from pinned tagv1.4.0to tracking the latest git revisionvcsc(anndata-VCSC) as a new dependencycupy-cuda12xreplacingcupy, plus CUDA toolkit wheels)Test plan
uv syncresolves cleanlypf2()runs withnormalize_slices=TrueandFalse🤖 Generated with Claude Code
https://claude.ai/code/session_015GRmxFJ5UZ4worNmd5gKfc