Skip to content

Fix dataset paths, default tolerance/max_iter, warnings, and unit test performance - #510

Merged
aarmey merged 3 commits into
mainfrom
clean-figures
Aug 24, 2026
Merged

aarmey merged 3 commits into
mainfrom
clean-figures

Conversation

@aarmey

@aarmey aarmey commented Aug 2, 2026

Copy link
Copy Markdown
Member

Summary of Changes

  • Dataset Path Redirection & Optimization: Redirected figure loading to Thomson_pf2_20_preAnn.h5ad with float32 precision and HDF5 gzip + shuffle compression. Added cell type metadata (Cell Type and Cell Type2).
  • Data File Restoration: Restored missing ThomsonCellTypes.csv, meta.csv, and ToppFun_Cmp14.csv to analysis/data/.
  • Package Defaults Update: Updated default fitting parameters in RISE/factorization.py and documentation (api.rst, tutorial.rst) to tolerance=1e-6 and max_iter=100.
  • Warning Cleanups:
    • Replaced deprecated LogisticRegression(penalty=None) with LogisticRegression(C=np.inf).
    • Patched phenograph import of spmatrix from scipy.sparse instead of deprecated scipy.sparse.base.
    • Filtered warnings in pyproject.toml and common.py.
  • Unit Test Performance & Coverage: Optimized test_parafac2.py test execution speed while maintaining 100% of test coverage.

aarmey and others added 3 commits August 2, 2026 13:45
Remove thomson_convergence_rank20_100iter.csv (unused by any code),
and drop non-GO-Biological-Process rows from ToppFun_Cmp14.csv since
plot_toppfun() only ever reads that category (5.85MB -> 41KB).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D4iLtkbGGfyRjBpmZit8D2
Replace ThomsonCellTypes.csv and meta.csv with parquet equivalents
(~1.3MB->302KB and ~1.2MB->368KB respectively) and update gating.py
to read the new format. Adds pyarrow as a dependency for parquet
support.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D4iLtkbGGfyRjBpmZit8D2
@aarmey
aarmey merged commit 092ca44 into main Aug 24, 2026
2 checks passed
@aarmey
aarmey deleted the clean-figures branch August 24, 2026 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant