Repository navigation
Fix dataset paths, default tolerance/max_iter, warnings, and unit test performance - #510
Merged
Merged
Conversation
Remove thomson_convergence_rank20_100iter.csv (unused by any code), and drop non-GO-Biological-Process rows from ToppFun_Cmp14.csv since plot_toppfun() only ever reads that category (5.85MB -> 41KB). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D4iLtkbGGfyRjBpmZit8D2
Replace ThomsonCellTypes.csv and meta.csv with parquet equivalents (~1.3MB->302KB and ~1.2MB->368KB respectively) and update gating.py to read the new format. Adds pyarrow as a dependency for parquet support. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D4iLtkbGGfyRjBpmZit8D2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Thomson_pf2_20_preAnn.h5adwithfloat32precision and HDF5gzip+shufflecompression. Added cell type metadata (Cell TypeandCell Type2).ThomsonCellTypes.csv,meta.csv, andToppFun_Cmp14.csvtoanalysis/data/.RISE/factorization.pyand documentation (api.rst,tutorial.rst) totolerance=1e-6andmax_iter=100.LogisticRegression(penalty=None)withLogisticRegression(C=np.inf).phenographimport ofspmatrixfromscipy.sparseinstead of deprecatedscipy.sparse.base.pyproject.tomlandcommon.py.test_parafac2.pytest execution speed while maintaining 100% of test coverage.