dependency bump: metatensor 0.9, metatomic 0.1.14, featomic 0.7.4#1144
Conversation
|
Featomic releases are now live on PyPI! |
|
The errors are super strange, they come from importing torch 😅 |
|
And in soap-bpnn we have problems, can they be because of torch-spex? |
|
Well, we have advanced to the next bug 😄 |
|
For the doc error I'm not sure where it comes from, but I'd fix the deprecation warnings and then check again. For the windows test build, it looks like the wheel for sphericart-torch fails to build on Windows, and this part of the code has been touched recently. I'd try to run with sphericart 1.0.8 to see if this helps, and otherwise we'll need to enable more verbose logs on CI. Also ping @frostedoyster in case you have an idea about what's going on here! |
Removed version constraint for 'featomic' package.
|
@sofiia-chorna could you try to build the documentation locally and see if you understand what's happening? |
|
|
Is there anything else above? |
|
examples seem to be generated cleanly but it crashes in |
|
did not manage to setup it on CI (torch cpu index) so far! on CI only tox -e tests fails due to setup, locally it passes: |
449c925 to
bc5f33d
Compare
bc5f33d to
8394fd3
Compare
…chorna/metatrain-js into bump-deps-metatensor-0.9
|
i think it remains to have the release of metatomic v0.1.14 publised metatensor/metatomic#231 and updated here and we are good? readthedocs fails due to the same issue as CI (fixed with temporal use of torch cpu index) |
|
cscs-ci run |
pfebrer
left a comment
There was a problem hiding this comment.
Ok, a couple things and we are good 👍
| "ignore:`compute_requested_neighbors_from_options` is deprecated and will be removed in a future version:UserWarning", | ||
| # metatomic 0.1.12 deprecations | ||
| "ignore:the 'features' output name is deprecated:UserWarning", | ||
| "ignore:the 'features' quantity is deprecated:UserWarning", | ||
| "ignore:the 'features' quantity is deprecated:DeprecationWarning", | ||
| "ignore:the 'non_conservative_forces' output name is deprecated:UserWarning", | ||
| "ignore:the 'momenta' quantity is deprecated:DeprecationWarning", | ||
| "ignore:the 'positions' quantity is deprecated:DeprecationWarning", | ||
| "ignore:the 'masses' quantity is deprecated:DeprecationWarning", | ||
| "ignore:the 'velocities' quantity is deprecated:DeprecationWarning", | ||
| "ignore:the 'charges' quantity is deprecated:DeprecationWarning", | ||
| "ignore:`per_atom` is deprecated:DeprecationWarning", | ||
| "ignore:ModelOutput.quantity is deprecated:DeprecationWarning" |
There was a problem hiding this comment.
We have to get rid of all these warnings ASAP after this PR 😅
There was a problem hiding this comment.
ok i will do it in the follow-up PR
b16bfae to
86ed229
Compare
|
cscs-ci run |
|
cscs-ci run |
|
Thank youuuu |
…lse) merge The reference fixture's storage changed slightly when the scaler switched from the manual TensorBlock rebuild to block.copy(deep=False) (from PR metatensor#1144). Regenerated via test_checkpoint_did_not_change.
The merge with PR metatensor#1144 replaced our regex catch-alls for torch.jit deprecations and the plural-name family ('features', 'positions', 'momenta', etc.) with PR metatensor#1144's narrower per-warning entries. macOS CI was failing 61 tests on a metatomic 0.1.14 UserWarning about Model.requested_inputs(use_new_names=False) that no remaining filter caught. Restore the regex catch-alls, add an explicit ignore for the new requested_inputs deprecation, and fix the one offending call site (cli/eval.py) to pass use_new_names=True so we no longer emit the warning from our own code.
reopen from #1128
dump to:
Please go the the
Previewtab and select the appropriate PR template:📚 Documentation preview 📚: https://metatrain--1144.org.readthedocs.build/en/1144/