Skip to content

Fix comments generated by ShankAccount seeds#60

Open
Juici wants to merge 1 commit into
metaplex-foundation:masterfrom
Juici:fix-comments
Open

Fix comments generated by ShankAccount seeds#60
Juici wants to merge 1 commit into
metaplex-foundation:masterfrom
Juici:fix-comments

Conversation

@Juici
Copy link
Copy Markdown

@Juici Juici commented Aug 22, 2023

Comments were being interpreted as string literals in generated code instead of as comments.

Comments were being interpreted as string literals in generated code
instead of as comments.
@vincentberthier
Copy link
Copy Markdown

Hello,
Can we get this merged to fix the seeds problem?

@febo
Copy link
Copy Markdown
Contributor

febo commented Aug 21, 2024

@Juici Did you try to use the syntax #[doc = ...] to render the comments? I think this will result in just a couple of files changed.

@Juici
Copy link
Copy Markdown
Author

Juici commented Aug 25, 2024

@Juici Did you try to use the syntax #[doc = ...] to render the comments? I think this will result in just a couple of files changed.

When I wrote the PR I just wanted to do a quick patch with minimal changes. Personally I think an approach using the quote! macro would be cleaner.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants