feat: add Python type conversion test#810
Conversation
|
hey harsh, been working on the same issue also acc. to me i think name test file as |
|
I started to implement support for type class but it's hard, I wanted to do this for each language for finishing the types left and create a table with all type conversions. In that way we can document it and also @ROKUMATE we can reason about the ABI breaking change respect to integer types. |
Also this is right. |
|
renamed the test to metacall_python_conversion_test |
|
I ran the CI, the ideal would be to progressively implement all types. But if we cannot, it would be good to make it return error or exception when a type is passed. I did this in node, it makes it silently fail but it's required for tests to pass. |
|
@Harsh-dev023 can you merge develop into this branch? The base |
|
Sorry I miss-clicked close PR. The base commit is a broken one. We were merging a big PR. Merge develop into this branch so the CI can run properly. |
|
I ran the CI. |
|
the Python Port tests pass on Ubuntu and Windows, but the macOS Python tests are crashing with a segmentation fault while running python test.py. I'm checking whether it's something introduced by the new type iteration test or an existing issue and will update you once I know more. |
|
You need to check here: https://github.com/metacall/core/actions/runs/27414380084/job/81024527223?pr=810 |
What
Added a type conversion test for the Python loader, similar to the existing Node.js conversion test.
Why
To check what type conversions happen when calling an identity function through the Python loader.
Changes
Notes