Repository navigation
ci(e2e): stabilize product category catalog assertions - #4018
Draft
jczhuoMeta wants to merge 1 commit into
Draft
jczhuoMeta wants to merge 1 commit into
jczhuoMeta wants to merge 1 commit into
Conversation
Contributor
📦 Latest Plugin BuildBuilt at: 2026-11-05T10:26:13Z Download: Click here to download the plugin To download: Click the link above → Scroll to bottom → Download "facebook-for-woocommerce" artifact |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4018 +/- ##
=======================================
Coverage ? 10.96%
Complexity ? 5948
=======================================
Files ? 227
Lines ? 20264
Branches ? 0
=======================================
Hits ? 2222
Misses ? 18042
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
10 of 12 tasks
vahidkay-meta
force-pushed
the
fix/product-category-e2e-stability
branch
from
November 5, 2026 10:25
b9425cd to
34fd3d7
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stabilizes the
product-categoryE2E shards after catalog writes were accepted but related products remained temporarily unavailable, or exposed stale product-set membership, during validation.term_taxonomy_idretailer ID and compares Meta IDs as strings to avoid unsafe integer coercion.This changes test infrastructure only. It does not modify plugin runtime behavior, WordPress user data, or database migrations.
Type of change
Checklist
Changelog entry
N/A — test infrastructure only.
Test Plan
node --checkon every changed JavaScript file..github/workflows/product-creation-tests.ymlas YAML.git diff --check.product-categoryE2E shards against the real Meta test assets.Expected CI behavior
Expected to pass:
E2E Tests - Currently supported - product-categoryE2E Tests - Latest - product-categoryExpected failure behavior:
product_setsresponse does not satisfy the category-deletion assertion.Asset separation is intentionally scoped to contention within one workflow run. Concurrent workflow runs may still share the finite asset pool; exact state polling and unique generated fixtures remain the correctness safeguards in that case.
Screenshots
Not applicable.