feat: update lightning example to lightning 2.0#603
Conversation
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
karthikprasad
left a comment
There was a problem hiding this comment.
Thanks for the PR! There is a minor bug in the variable name. I'm surprised the integration test passed despite this though.
|
@lsc64 has updated the pull request. You must reimport the pull request before landing. |
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
One could think it’s possible to add two lines without a major oversight, but here we are… thanks, I’ve changed it! |
|
@lsc64 has updated the pull request. You must reimport the pull request before landing. |
|
@lsc64 has updated the pull request. You must reimport the pull request before landing. |
|
friendly ping @karthikprasad |
Co-authored-by: Karthik Prasad <prasadkr@uci.edu>
Types of changes
Motivation and Context / Related issue
Updates the lightning example to use a less hacky way to change datamodules.
Lightning-AI/pytorch-lightning#10430
How Has This Been Tested (if it applies)
Checklist